Re: [Intel-gfx] [PATCH 3/5] drm/i915/dsi: Add some debug logging to mipi_exec_i2c

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 25 Feb 2022, Hans de Goede <hdegoede@redhat.com> wrote:
> Add some debug logging to mipi_exec_i2c, to make debugging various
> issues seen with it easier.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> index 0da91849efde..215dbfc0af0f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> @@ -464,6 +464,10 @@ static const u8 *mipi_exec_i2c(struct intel_dsi *intel_dsi, const u8 *data)
>  	u8 payload_size = *(data + 6);
>  	u8 *payload_data;
>  
> +	drm_dbg_kms(&i915->drm, "%s bus %d client-addr 0x%02x reg 0x%02x data %*ph\n",
> +		    __func__, vbt_i2c_bus_num, slave_addr, reg_offset,

__func__ is redundant with drm_dbg_kms.

BR,
Jani.

> +		    payload_size, data + 7);
> +
>  	if (intel_dsi->i2c_bus_num < 0) {
>  		intel_dsi->i2c_bus_num = vbt_i2c_bus_num;
>  		i2c_acpi_find_adapter(intel_dsi, slave_addr);

-- 
Jani Nikula, Intel Open Source Graphics Center