Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Dsiplay13 HDCP support over MST
Date: Mon, 05 Jul 2021 15:01:27 +0300	[thread overview]
Message-ID: <87sg0t7yw8.fsf@intel.com> (raw)
In-Reply-To: <20210705113706.18474-1-anshuman.gupta@intel.com>

On Mon, 05 Jul 2021, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
> Adding HDCP support over DP MST for Display13 Platforms.

Why do we have the condition at all? Usually we assume it'll work, and
we disable or change later when a platform shows up where it doesn't
work.

BR,
Jani.

>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 70fe90beaf6c..15d90d9456dc 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -835,7 +835,7 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo
>  	intel_attach_force_audio_property(connector);
>  	intel_attach_broadcast_rgb_property(connector);
>  
> -	if (DISPLAY_VER(dev_priv) <= 12) {
> +	if (DISPLAY_VER(dev_priv) <= 13) {
>  		ret = intel_dp_hdcp_init(dig_port, intel_connector);
>  		if (ret)
>  			drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP MST init failed, skipping.\n",

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-07-05 12:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 11:37 [Intel-gfx] [PATCH] drm/i915/hdcp: Dsiplay13 HDCP support over MST Anshuman Gupta
2021-07-05 12:01 ` Jani Nikula [this message]
2021-07-05 12:22 ` [Intel-gfx] [PATCH v2] drm/i915/hdcp: Nuke Platform check for mst hdcp init Anshuman Gupta
2021-07-06  7:30   ` Jani Nikula
2021-07-05 12:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Dsiplay13 HDCP support over MST Patchwork
2021-07-05 13:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Dsiplay13 HDCP support over MST (rev2) Patchwork
2021-07-06 14:50   ` Gupta, Anshuman
2021-07-06 16:42     ` Vudum, Lakshminarayana
2021-07-07 10:50       ` Gupta, Anshuman
2021-07-06 16:00 ` Patchwork
2021-07-06 16:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-06 18:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg0t7yw8.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox