From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs
Date: Thu, 21 Jan 2021 13:32:26 +0200 [thread overview]
Message-ID: <87sg6ujzjp.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20210120121718.26435-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Treat the dependency between bonded requests as weak and leave the
> remainder of the pair on the GPU if one hangs.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> index 740ff05fd692..524c8b54d220 100644
> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> @@ -1990,6 +1990,9 @@ static void __execlists_hold(struct i915_request *rq)
> struct i915_request *w =
> container_of(p->waiter, typeof(*w), sched);
>
> + if (p->flags & I915_DEPENDENCY_WEAK)
> + continue;
> +
> /* Leave semaphores spinning on the other engines */
> if (w->engine != rq->engine)
> continue;
> @@ -2088,6 +2091,9 @@ static void __execlists_unhold(struct i915_request *rq)
> struct i915_request *w =
> container_of(p->waiter, typeof(*w), sched);
>
> + if (p->flags & I915_DEPENDENCY_WEAK)
> + continue;
> +
> /* Propagate any change in error status */
> if (rq->fence.error)
> i915_request_set_error_once(w, rq->fence.error);
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-21 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 12:17 [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Chris Wilson
2021-01-20 12:17 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Skip over completed active execlists, again Chris Wilson
2021-01-21 11:47 ` Mika Kuoppala
2021-01-20 19:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Patchwork
2021-01-20 22:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-21 11:32 ` Mika Kuoppala [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-18 12:43 [Intel-gfx] [PATCH 1/2] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg6ujzjp.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox