Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 04/11] drm/i915/icl: WaEnableFloatBlendOptimization
Date: Tue, 29 May 2018 15:07:27 +0300	[thread overview]
Message-ID: <87sh6a7ji8.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <1527285939-20113-5-git-send-email-oscar.mateo@intel.com>

Oscar Mateo <oscar.mateo@intel.com> writes:

> Enables blend optimization for floating point RTs
>
> v2: Rebased on top of the WA refactoring
> v3: Added References (Mika)
>
> References: HSDES#1406393558
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>

Let's see if we can get away without whitelisting this,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_reg.h          | 3 +++
>  drivers/gpu/drm/i915/intel_workarounds.c | 3 +++
>  2 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 6e88c6b..f123c3e 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2663,6 +2663,9 @@ enum i915_power_well_id {
>  #define   GEN8_4x4_STC_OPTIMIZATION_DISABLE	(1<<6)
>  #define   GEN9_PARTIAL_RESOLVE_IN_VC_DISABLE	(1<<1)
>  
> +#define GEN10_CACHE_MODE_SS			_MMIO(0xe420)
> +#define   FLOAT_BLEND_OPTIMIZATION_ENABLE	(1 << 4)
> +
>  #define GEN6_BLITTER_ECOSKPD	_MMIO(0x221d0)
>  #define   GEN6_BLITTER_LOCK_SHIFT			16
>  #define   GEN6_BLITTER_FBC_NOTIFY			(1<<3)
> diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
> index 33a1a0c..e9c00b0 100644
> --- a/drivers/gpu/drm/i915/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/intel_workarounds.c
> @@ -479,6 +479,9 @@ static int icl_ctx_workarounds_init(struct drm_i915_private *dev_priv)
>  		WA_SET_BIT_MASKED(GEN11_COMMON_SLICE_CHICKEN3,
>  				  GEN11_BLEND_EMB_FIX_DISABLE_IN_RCC);
>  
> +	/* WaEnableFloatBlendOptimization:icl */
> +	WA_SET_BIT_MASKED(GEN10_CACHE_MODE_SS, FLOAT_BLEND_OPTIMIZATION_ENABLE);
> +
>  	return 0;
>  }
>  
> -- 
> 1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-05-29 12:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 22:05 [PATCH v4 00/11] Workarounds for Icelake Oscar Mateo
2018-05-25 22:05 ` [PATCH 01/11] drm/i915/icl: WaDisableImprovedTdlClkGating Oscar Mateo
2018-05-29  8:51   ` Mika Kuoppala
2018-05-25 22:05 ` [PATCH 02/11] drm/i915/icl: WaEnableStateCacheRedirectToCS Oscar Mateo
2018-05-29  9:15   ` Mika Kuoppala
2018-05-25 22:05 ` [PATCH 03/11] drm/i915/icl: Wa_2006665173 Oscar Mateo
2018-05-29 10:37   ` Mika Kuoppala
2018-05-25 22:05 ` [PATCH 04/11] drm/i915/icl: WaEnableFloatBlendOptimization Oscar Mateo
2018-05-29 12:07   ` Mika Kuoppala [this message]
2018-05-29 12:47     ` Lionel Landwerlin
2018-05-29 19:13       ` Anuj Phogat
2018-07-23 12:03   ` Chris Wilson
2018-05-25 22:05 ` [PATCH 05/11] drm/i915/icl: WaSendPushConstantsFromMMIO Oscar Mateo
2018-05-25 22:05 ` [PATCH 06/11] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken2 Oscar Mateo
2018-05-25 22:05 ` [PATCH 07/11] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7 Oscar Mateo
2018-05-25 22:05 ` [PATCH 08/11] drm/i915/icl: WaAllowUmdWriteTRTTRootTable Oscar Mateo
2018-05-25 22:05 ` [PATCH 09/11] drm/i915/icl: WaAllowUMDToModifySamplerMode Oscar Mateo
2018-05-25 22:05 ` [PATCH 10/11] drm/i915/icl: WaEnablePreemptionGranularityControlByUMD Oscar Mateo
2018-05-25 22:05 ` [PATCH 11/11] drm/i915/icl: Wa_1406463099 Oscar Mateo
2018-05-29 12:40   ` Mika Kuoppala
2018-05-25 22:57 ` ✓ Fi.CI.BAT: success for Workarounds for Icelake (rev4) Patchwork
2018-05-26  9:37 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-29 13:03 ` [PATCH v4 00/11] Workarounds for Icelake Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh6a7ji8.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=oscar.mateo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox