From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: remove redundant (and incorrect!) dither enable for VLV
Date: Mon, 22 Apr 2013 11:58:10 +0300 [thread overview]
Message-ID: <87sj2jymal.fsf@intel.com> (raw)
In-Reply-To: <1366388748-3456-1-git-send-email-jbarnes@virtuousgeek.org>
On Fri, 19 Apr 2013, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> We already enable dithering above if needed, and we definitely shouldn't
> be enabling the pipe at this point, so just drop this whole block.
This gets rid of the pipe enabled when expected off backtrace I kept
having.
Tested-by: Jani Nikula <jani.nikula@intel.com>
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> drivers/gpu/drm/i915/intel_display.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 299208d..9f76f76 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4721,15 +4721,6 @@ static void i9xx_set_pipeconf(struct intel_crtc *intel_crtc)
> }
> }
>
> - if (IS_VALLEYVIEW(dev) && intel_pipe_has_type(&intel_crtc->base,
> - INTEL_OUTPUT_EDP)) {
> - if (intel_crtc->config.dither) {
> - pipeconf |= PIPECONF_6BPC |
> - PIPECONF_ENABLE |
> - I965_PIPECONF_ACTIVE;
> - }
> - }
> -
> if (HAS_PIPE_CXSR(dev)) {
> if (intel_crtc->lowfreq_avail) {
> DRM_DEBUG_KMS("enabling CxSR downclocking\n");
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2013-04-22 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 16:25 [PATCH] drm/i915: remove redundant (and incorrect!) dither enable for VLV Jesse Barnes
2013-04-22 8:58 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj2jymal.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox