From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/quirks: make intel_dpcd_quirks const
Date: Mon, 23 Sep 2024 10:33:16 +0300 [thread overview]
Message-ID: <87tte67rk3.fsf@intel.com> (raw)
In-Reply-To: <ZuxuouVHVBIRZwAW@intel.com>
On Thu, 19 Sep 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Sep 19, 2024 at 06:33:54PM +0300, Jani Nikula wrote:
>> The array can be in rodate, make it const.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, pushed to din.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_quirks.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c
>> index 29b56d53a340..28f497ae785b 100644
>> --- a/drivers/gpu/drm/i915/display/intel_quirks.c
>> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
>> @@ -231,7 +231,7 @@ static struct intel_quirk intel_quirks[] = {
>> { 0x0f31, 0x103c, 0x220f, quirk_invert_brightness },
>> };
>>
>> -static struct intel_dpcd_quirk intel_dpcd_quirks[] = {
>> +static const struct intel_dpcd_quirk intel_dpcd_quirks[] = {
>> /* Dell Precision 5490 */
>> {
>> .device = 0x7d55,
>> @@ -272,7 +272,7 @@ void intel_init_dpcd_quirks(struct intel_dp *intel_dp,
>> int i;
>>
>> for (i = 0; i < ARRAY_SIZE(intel_dpcd_quirks); i++) {
>> - struct intel_dpcd_quirk *q = &intel_dpcd_quirks[i];
>> + const struct intel_dpcd_quirk *q = &intel_dpcd_quirks[i];
>>
>> if (d->device == q->device &&
>> (d->subsystem_vendor == q->subsystem_vendor ||
>> --
>> 2.39.2
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-23 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 15:33 [PATCH] drm/i915/quirks: make intel_dpcd_quirks const Jani Nikula
2024-09-19 18:34 ` Ville Syrjälä
2024-09-23 7:33 ` Jani Nikula [this message]
2024-09-20 6:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-09-20 23:00 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tte67rk3.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox