From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dg2: Implement WM0 cursor WA for DG2
Date: Wed, 24 Nov 2021 12:57:22 +0200 [thread overview]
Message-ID: <87tug1lt2l.fsf@intel.com> (raw)
In-Reply-To: <20211124103300.GA4169@intel.com>
On Wed, 24 Nov 2021, "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com> wrote:
> On Wed, Nov 24, 2021 at 12:23:08PM +0200, Jani Nikula wrote:
>> On Thu, 18 Nov 2021, Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> wrote:
>> > +static bool icl_need_wm1_wa(struct drm_i915_private *i915,
>> > + enum plane_id plane_id)
>>
>> Commit subject having "WM0 cursor WA" and the function saying "wm1_wa"
>> looks like a discrepancy to the casual reader.
>
> Agree, not the best naming. Should be either WM0 or WM1.
> Thing is that due to nature of that W/A both can be correct.
> Patch has been pushed week ago, after r-b from Ville.
>
> I will send a fix anyway.
*shrug* Not sure it matters, just an observation going through mails.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-11-24 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 9:39 [Intel-gfx] [PATCH] drm/i915/dg2: Implement WM0 cursor WA for DG2 Stanislav Lisovskiy
2021-11-18 14:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Implement WM0 cursor WA for DG2 (rev2) Patchwork
2021-11-19 2:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-11-24 10:23 ` [Intel-gfx] [PATCH] drm/i915/dg2: Implement WM0 cursor WA for DG2 Jani Nikula
2021-11-24 10:33 ` Lisovskiy, Stanislav
2021-11-24 10:57 ` Jani Nikula [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-17 13:43 Stanislav Lisovskiy
2021-11-17 15:48 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tug1lt2l.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stanislav.lisovskiy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox