From: Jani Nikula <jani.nikula@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: "Radhakrishna Sripada" <radhakrishna.sripada@intel.com>,
"Matt Atwood" <matthew.s.atwood@intel.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
ville.syrjala@linux.intel.com,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add struct to hold IP version
Date: Wed, 20 Oct 2021 12:47:11 +0300 [thread overview]
Message-ID: <87tuhcni3k.fsf@intel.com> (raw)
In-Reply-To: <20211020002353.193893-1-jose.souza@intel.com>
On Tue, 19 Oct 2021, José Roberto de Souza <jose.souza@intel.com> wrote:
> The constant platform display version is not using this new struct but
> the runtime variant will definitely use it.
Cc: Some more folks to hijack this thread. Sorry! ;)
We added runtime info to i915, because we had this idea and goal of
turning the device info to a truly const pointer to the info structures
in i915_pci.c that are stored in rodata. The idea was that we'll have a
complete split of mutable and immutable device data, with all the
mutable data in runtime info.
Alas, we never got there. More and more data that was mostly const but
sometimes needed tweaking kept piling up. mkwrite_device_info() was
supposed to be a clue not to modify device info runtime, but instead it
proliferated. Now we have places like intel_fbc_init() disabling FBC
through that. But most importantly, we have fusing that considerably
changes the device info, and the copying all of that data over to
runtime info probably isn't worth it.
Should we just acknowledge that the runtime info is useless, and move
some of that data to intel_device_info and some of it elsewhere in i915?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-10-20 9:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 0:23 [Intel-gfx] [PATCH 1/3] drm/i915: Add struct to hold IP version José Roberto de Souza
2021-10-20 0:23 ` [Intel-gfx] [PATCH 2/3] drm/i915: Track media IP stepping separated from GT José Roberto de Souza
2021-11-02 7:30 ` Lucas De Marchi
2021-10-20 0:23 ` [Intel-gfx] [PATCH 3/3] drm/i915: Rename GT_STEP to GRAPHICS_STEP José Roberto de Souza
2021-10-20 15:06 ` Yokoyama, Caz
2021-11-02 7:27 ` Lucas De Marchi
2021-10-20 0:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Add struct to hold IP version Patchwork
2021-10-20 1:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-20 5:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-02 20:04 ` Souza, Jose
2021-10-20 9:47 ` Jani Nikula [this message]
2021-10-20 19:29 ` [Intel-gfx] [PATCH 1/3] " Souza, Jose
2021-10-21 13:11 ` Jani Nikula
2021-10-22 20:15 ` Lucas De Marchi
2021-10-25 9:04 ` Jani Nikula
2021-11-02 5:33 ` Souza, Jose
2021-10-20 15:00 ` Yokoyama, Caz
2021-10-20 19:19 ` Souza, Jose
2021-10-22 21:26 ` Yokoyama, Caz
2021-10-28 21:08 ` Souza, Jose
2021-11-01 14:29 ` Yokoyama, Caz
2021-11-02 7:32 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuhcni3k.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jose.souza@intel.com \
--cc=matthew.s.atwood@intel.com \
--cc=radhakrishna.sripada@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox