Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915/dmc: s/intel_csr.c/intel_dmc.c and s/intel_csr.h/intel_dmc.h
Date: Wed, 12 May 2021 16:38:15 +0300	[thread overview]
Message-ID: <87tun8t6m0.fsf@intel.com> (raw)
In-Reply-To: <20210511231757.14873-6-anusha.srivatsa@intel.com>

On Tue, 11 May 2021, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> Finally, rename the header and source file from csr to dmc.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  drivers/gpu/drm/i915/Makefile                             | 2 +-
>  drivers/gpu/drm/i915/display/intel_display.c              | 2 +-
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c      | 2 +-
>  drivers/gpu/drm/i915/display/intel_display_power.c        | 2 +-
>  drivers/gpu/drm/i915/display/{intel_csr.c => intel_dmc.c} | 2 +-
>  drivers/gpu/drm/i915/display/{intel_csr.h => intel_dmc.h} | 6 +++---
>  drivers/gpu/drm/i915/i915_drv.c                           | 2 +-
>  drivers/gpu/drm/i915/i915_gpu_error.c                     | 2 +-
>  8 files changed, 10 insertions(+), 10 deletions(-)
>  rename drivers/gpu/drm/i915/display/{intel_csr.c => intel_dmc.c} (99%)
>  rename drivers/gpu/drm/i915/display/{intel_csr.h => intel_dmc.h} (88%)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index d0d936d9137b..f1099b6bfed5 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -201,7 +201,7 @@ i915-y += \
>  	display/intel_combo_phy.o \
>  	display/intel_connector.o \
>  	display/intel_crtc.o \
> -	display/intel_csr.o \
> +	display/intel_dmc.o \

Nitpick, please keep the file lists and #include lists sorted.

BR,
Jani.

>  	display/intel_cursor.o \
>  	display/intel_display.o \
>  	display/intel_display_power.o \
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 4efb5d28712c..b4db770d7c74 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -79,7 +79,7 @@
>  #include "intel_cdclk.h"
>  #include "intel_color.h"
>  #include "intel_crtc.h"
> -#include "intel_csr.h"
> +#include "intel_dmc.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
>  #include "intel_dp_link_training.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 5ed8996eacb4..0537a1f6bfbb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -7,7 +7,7 @@
>  #include <drm/drm_fourcc.h>
>  
>  #include "i915_debugfs.h"
> -#include "intel_csr.h"
> +#include "intel_dmc.h"
>  #include "intel_display_debugfs.h"
>  #include "intel_display_power.h"
>  #include "intel_de.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 72f6e1ea711a..1acacba2735f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -9,7 +9,7 @@
>  #include "i915_irq.h"
>  #include "intel_cdclk.h"
>  #include "intel_combo_phy.h"
> -#include "intel_csr.h"
> +#include "intel_dmc.h"
>  #include "intel_display_power.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> similarity index 99%
> rename from drivers/gpu/drm/i915/display/intel_csr.c
> rename to drivers/gpu/drm/i915/display/intel_dmc.c
> index 2d8b6f2fed7f..7e438e4a6f2b 100644
> --- a/drivers/gpu/drm/i915/display/intel_csr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -26,7 +26,7 @@
>  
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> -#include "intel_csr.h"
> +#include "intel_dmc.h"
>  #include "intel_de.h"
>  
>  /**
> diff --git a/drivers/gpu/drm/i915/display/intel_csr.h b/drivers/gpu/drm/i915/display/intel_dmc.h
> similarity index 88%
> rename from drivers/gpu/drm/i915/display/intel_csr.h
> rename to drivers/gpu/drm/i915/display/intel_dmc.h
> index fc4960b91686..57dd99da0ced 100644
> --- a/drivers/gpu/drm/i915/display/intel_csr.h
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.h
> @@ -3,8 +3,8 @@
>   * Copyright © 2019 Intel Corporation
>   */
>  
> -#ifndef __INTEL_CSR_H__
> -#define __INTEL_CSR_H__
> +#ifndef __INTEL_DMC_H__
> +#define __INTEL_DMC_H__
>  
>  struct drm_i915_private;
>  
> @@ -18,4 +18,4 @@ void intel_dmc_ucode_fini(struct drm_i915_private *i915);
>  void intel_dmc_ucode_suspend(struct drm_i915_private *i915);
>  void intel_dmc_ucode_resume(struct drm_i915_private *i915);
>  
> -#endif /* __INTEL_CSR_H__ */
> +#endif /* __INTEL_DMC_H__ */
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index f2a9583dfecc..2f06bb7b3ed2 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -49,7 +49,7 @@
>  #include "display/intel_acpi.h"
>  #include "display/intel_bw.h"
>  #include "display/intel_cdclk.h"
> -#include "display/intel_csr.h"
> +#include "display/intel_dmc.h"
>  #include "display/intel_display_types.h"
>  #include "display/intel_dp.h"
>  #include "display/intel_fbdev.h"
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 0af5abc48093..df8dd22655ab 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -36,7 +36,7 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "display/intel_csr.h"
> +#include "display/intel_dmc.h"
>  #include "display/intel_overlay.h"
>  
>  #include "gem/i915_gem_context.h"

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-05-12 13:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 23:17 [Intel-gfx] [PATCH 0/5] Rename all CSR references to DMC Anusha Srivatsa
2021-05-11 23:17 ` [Intel-gfx] [PATCH 1/5] drm/i915/dmc: s/intel_csr/intel_dmc Anusha Srivatsa
2021-05-11 23:17 ` [Intel-gfx] [PATCH 2/5] drm/i915/dmc: s/HAS_CSR/HAS_DMC Anusha Srivatsa
2021-05-11 23:17 ` [Intel-gfx] [PATCH 3/5] drm/i915/dmc: Rename macro names containing csr Anusha Srivatsa
2021-05-11 23:17 ` [Intel-gfx] [PATCH 4/5] drm/i915/dmc: Rename functions names having "csr" Anusha Srivatsa
2021-05-11 23:17 ` [Intel-gfx] [PATCH 5/5] drm/i915/dmc: s/intel_csr.c/intel_dmc.c and s/intel_csr.h/intel_dmc.h Anusha Srivatsa
2021-05-12 13:38   ` Jani Nikula [this message]
2021-05-12 16:41     ` Srivatsa, Anusha
2021-05-11 23:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Rename all CSR references to DMC Patchwork
2021-05-11 23:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-05-11 23:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-05-12  0:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-05-12 13:40 ` [Intel-gfx] [PATCH 0/5] " Jani Nikula
  -- strict thread matches above, loose matches on Subject: below --
2021-05-14 22:57 Anusha Srivatsa
2021-05-14 22:57 ` [Intel-gfx] [PATCH 5/5] drm/i915/dmc: s/intel_csr.c/intel_dmc.c and s/intel_csr.h/intel_dmc.h Anusha Srivatsa
2021-05-17 19:50 [Intel-gfx] [PATCH 0/5] Rename all CSR references to DMC Anusha Srivatsa
2021-05-17 19:50 ` [Intel-gfx] [PATCH 5/5] drm/i915/dmc: s/intel_csr.c/intel_dmc.c and s/intel_csr.h/intel_dmc.h Anusha Srivatsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tun8t6m0.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=anusha.srivatsa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox