From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Check for scratch page scribbling
Date: Wed, 10 Feb 2021 13:51:57 +0200 [thread overview]
Message-ID: <87tuqkta1u.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <161295538791.6673.11947302575703134520@build.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2021-02-10 10:49:55)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>> > diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c
>> > index d34770ae4c9a..5ac9eb4a3a92 100644
>> > --- a/drivers/gpu/drm/i915/gt/intel_gtt.c
>> > +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c
>> > @@ -158,10 +158,49 @@ static void poison_scratch_page(struct drm_i915_gem_object *scratch)
>> >
>> > vaddr = kmap(page);
>> > memset(vaddr, val, PAGE_SIZE);
>> > + set_page_dirty(page); /* keep the poisoned contents */
>>
>> Should we use locked version in here?
>
> We don't hold the page-lock here, so no. If this is not an anonymous
> page, something is very wrong :p
Cleared confusion in irc. We dont hold the lock and set_page_dirty dont
take it.
But this is anonymous page and we are sole user during poisoning.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-10 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 10:22 [Intel-gfx] [PATCH 1/2] drm/i915: Check for scratch page scribbling Chris Wilson
2021-02-10 10:22 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Correct surface base address Chris Wilson
2021-02-10 10:50 ` Mika Kuoppala
2021-02-10 12:21 ` Chris Wilson
2021-02-10 10:49 ` [Intel-gfx] [PATCH 1/2] drm/i915: Check for scratch page scribbling Mika Kuoppala
2021-02-10 11:09 ` Chris Wilson
2021-02-10 11:51 ` Mika Kuoppala [this message]
2021-02-10 11:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] " Patchwork
2021-02-10 12:16 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuqkta1u.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox