From: Jani Nikula <jani.nikula@intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/perf: make oa format tables const
Date: Thu, 14 Jun 2018 13:54:11 +0300 [thread overview]
Message-ID: <87tvq5zlik.fsf@intel.com> (raw)
In-Reply-To: <309ded78-67c1-c208-fa26-cb060bfe7b2b@intel.com>
On Wed, 13 Jun 2018, Lionel Landwerlin <lionel.g.landwerlin@intel.com> wrote:
> On 13/06/18 12:49, Jani Nikula wrote:
>> No reason not to be const.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Pushed to dinq, thanks for the review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/i915_perf.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>> index 881a992305ec..447407fee3b8 100644
>> --- a/drivers/gpu/drm/i915/i915_perf.c
>> +++ b/drivers/gpu/drm/i915/i915_perf.c
>> @@ -315,7 +315,7 @@ static u32 i915_oa_max_sample_rate = 100000;
>> * code assumes all reports have a power-of-two size and ~(size - 1) can
>> * be used as a mask to align the OA tail pointer.
>> */
>> -static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX] = {
>> +static const struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX] = {
>> [I915_OA_FORMAT_A13] = { 0, 64 },
>> [I915_OA_FORMAT_A29] = { 1, 128 },
>> [I915_OA_FORMAT_A13_B8_C8] = { 2, 128 },
>> @@ -326,7 +326,7 @@ static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX] = {
>> [I915_OA_FORMAT_C4_B8] = { 7, 64 },
>> };
>>
>> -static struct i915_oa_format gen8_plus_oa_formats[I915_OA_FORMAT_MAX] = {
>> +static const struct i915_oa_format gen8_plus_oa_formats[I915_OA_FORMAT_MAX] = {
>> [I915_OA_FORMAT_A12] = { 0, 64 },
>> [I915_OA_FORMAT_A12_B8_C8] = { 2, 128 },
>> [I915_OA_FORMAT_A32u40_A4u32_B8_C8] = { 5, 256 },
>
>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-14 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 11:49 [PATCH] drm/i915/perf: make oa format tables const Jani Nikula
2018-06-13 11:53 ` Lionel Landwerlin
2018-06-14 10:54 ` Jani Nikula [this message]
2018-06-13 13:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-13 16:39 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvq5zlik.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox