From: Jani Nikula <jani.nikula@intel.com>
To: "Sharma, Shashank" <shashank.sharma@intel.com>,
dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/scdc: declare drm_scdc_get_scrambling_status
Date: Thu, 23 Mar 2017 15:01:32 +0200 [thread overview]
Message-ID: <87tw6k6tar.fsf@intel.com> (raw)
In-Reply-To: <7001997e-cc86-9615-bb98-339cb83dec88@intel.com>
On Wed, 22 Mar 2017, "Sharma, Shashank" <shashank.sharma@intel.com> wrote:
> Thanks for this patch, Jani.
>
> Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
And pushed to drm-misc-next, thanks for the review.
BR,
Jani.
>
>
> Regards
> Shashank
> On 3/22/2017 4:33 PM, Jani Nikula wrote:
>> Fix sparse warning:
>>
>> drivers/gpu/drm/drm_scdc_helper.c:138:6: warning: symbol
>> 'drm_scdc_get_scrambling_status' was not declared. Should it be static?
>>
>> Fixes: 62c58af32c93 ("drm/edid: detect SCDC support in HF-VSDB")
>> Cc: Shashank Sharma <shashank.sharma@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> include/drm/drm_scdc_helper.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h
>> index ab6bcfbceba9..c25122bb490a 100644
>> --- a/include/drm/drm_scdc_helper.h
>> +++ b/include/drm/drm_scdc_helper.h
>> @@ -129,6 +129,8 @@ static inline int drm_scdc_writeb(struct i2c_adapter *adapter, u8 offset,
>> return drm_scdc_write(adapter, offset, &value, sizeof(value));
>> }
>>
>> +bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter);
>> +
>> /**
>> * drm_scdc_set_scrambling - enable scrambling
>> * @adapter: I2C adapter for DDC channel
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-03-23 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 14:33 [PATCH] drm/scdc: declare drm_scdc_get_scrambling_status Jani Nikula
2017-03-22 14:51 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-22 14:57 ` [PATCH] " Sharma, Shashank
2017-03-23 13:01 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw6k6tar.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shashank.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox