From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Reduce DDI clock gating printk level from NOTICE to DEBUG
Date: Wed, 05 Jun 2024 14:40:24 +0300 [thread overview]
Message-ID: <87v82nbot3.fsf@intel.com> (raw)
In-Reply-To: <20240605113336.11194-1-ville.syrjala@linux.intel.com>
On Wed, 05 Jun 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> No idea why the DDI clock gating print is done with drm_notice().
> Just use drm_dbg_kms() since no one is going to be interested in
> this under normal circumstances.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 3c3fc53376ce..c76bbd13bb27 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2072,9 +2072,9 @@ void intel_ddi_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
> !encoder->is_clock_enabled(encoder))
> return;
>
> - drm_notice(&i915->drm,
> - "[ENCODER:%d:%s] is disabled/in DSI mode with an ungated DDI clock, gate it\n",
> - encoder->base.base.id, encoder->base.name);
> + drm_dbg_kms(&i915->drm,
> + "[ENCODER:%d:%s] is disabled/in DSI mode with an ungated DDI clock, gate it\n",
> + encoder->base.base.id, encoder->base.name);
>
> encoder->disable_clock(encoder);
> }
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-06-05 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 11:33 [PATCH] drm/i915: Reduce DDI clock gating printk level from NOTICE to DEBUG Ville Syrjala
2024-06-05 11:40 ` Jani Nikula [this message]
2024-06-05 14:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-06-05 19:51 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v82nbot3.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox