From: Jani Nikula <jani.nikula@intel.com>
To: Vandita Kulkarni <vandita.kulkarni@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vbt: Fix the timing parameters
Date: Mon, 27 Jan 2020 11:59:45 +0200 [thread overview]
Message-ID: <87v9oxb4oe.fsf@intel.com> (raw)
In-Reply-To: <87eevpgchn.fsf@intel.com>
On Fri, 24 Jan 2020, Jani Nikula <jani.nikula@intel.com> wrote:
> On Fri, 24 Jan 2020, Vandita Kulkarni <vandita.kulkarni@intel.com> wrote:
>> Fix htotal and vtotal parameters derived from
>> DTD block of VBT.
>>
>> Fixes: 33ef6d4fd8df ("drm/i915/vbt: Handle generic DTD block")
>> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
And pushed, thanks for the patch. Amended the commit message to explain
that the total values were missing the back porch size.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> index 1e675aa55938..942a073d5768 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -366,14 +366,16 @@ parse_generic_dtd(struct drm_i915_private *dev_priv,
>> panel_fixed_mode->hdisplay + dtd->hfront_porch;
>> panel_fixed_mode->hsync_end =
>> panel_fixed_mode->hsync_start + dtd->hsync;
>> - panel_fixed_mode->htotal = panel_fixed_mode->hsync_end;
>> + panel_fixed_mode->htotal =
>> + panel_fixed_mode->hdisplay + dtd->hblank;
>>
>> panel_fixed_mode->vdisplay = dtd->vactive;
>> panel_fixed_mode->vsync_start =
>> panel_fixed_mode->vdisplay + dtd->vfront_porch;
>> panel_fixed_mode->vsync_end =
>> panel_fixed_mode->vsync_start + dtd->vsync;
>> - panel_fixed_mode->vtotal = panel_fixed_mode->vsync_end;
>> + panel_fixed_mode->vtotal =
>> + panel_fixed_mode->vdisplay + dtd->vblank;
>>
>> panel_fixed_mode->clock = dtd->pixel_clock;
>> panel_fixed_mode->width_mm = dtd->width_mm;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-27 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 12:58 [Intel-gfx] [PATCH] drm/i915/vbt: Fix the timing parameters Vandita Kulkarni
2020-01-24 14:23 ` Jani Nikula
2020-01-27 9:59 ` Jani Nikula [this message]
2020-01-24 20:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-27 3:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9oxb4oe.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vandita.kulkarni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox