From: Jani Nikula <jani.nikula@intel.com>
To: imre.deak@intel.com, Anshuman Gupta <anshuman.gupta@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v9 3/7] drm/i915/tgl: Enable DC3CO state in "DC Off" power well
Date: Fri, 27 Sep 2019 16:40:59 +0300 [thread overview]
Message-ID: <87v9tddfh0.fsf@intel.com> (raw)
In-Reply-To: <20190927133248.GB29139@ideak-desk.fi.intel.com>
On Fri, 27 Sep 2019, Imre Deak <imre.deak@intel.com> wrote:
> On Fri, Sep 27, 2019 at 02:07:43PM +0300, Imre Deak wrote:
>> On Thu, Sep 26, 2019 at 08:26:17PM +0530, Anshuman Gupta wrote:
>> > +void tgl_set_target_dc_state(struct drm_i915_private *dev_priv, u32 state)
>
> We need a documentation for exported functions.
And really you should make an effort to *NOT* expose platform specific
functions from your C modules. Yes, we have some, but the direction
should be the opposite of adding more.
I'll be more strict about this going forward. We need to improve the
interfaces we have.
>> > @@ -256,6 +257,7 @@ void intel_display_power_suspend_late(struct drm_i915_private *i915);
>> > void intel_display_power_resume_early(struct drm_i915_private *i915);
>> > void intel_display_power_suspend(struct drm_i915_private *i915);
>> > void intel_display_power_resume(struct drm_i915_private *i915);
>> > +void tgl_set_target_dc_state(struct drm_i915_private *dev_priv, u32 state);
This sticks out like a sore thumb.
And you're not even using the function outside of intel_display_power.h!
BR,
Jani.
>> >
>> > const char *
>> > intel_display_power_domain_str(enum intel_display_power_domain domain);
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-09-27 13:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 14:56 [PATCH RESEND v9 0/7] DC3CO Support for TGL Anshuman Gupta
2019-09-26 14:56 ` [PATCH v9 1/7] drm/i915/tgl: Add DC3CO required register and bits Anshuman Gupta
2019-09-26 14:56 ` [PATCH v9 2/7] drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_mask Anshuman Gupta
2019-09-26 14:56 ` [PATCH v9 3/7] drm/i915/tgl: Enable DC3CO state in "DC Off" power well Anshuman Gupta
2019-09-27 11:07 ` Imre Deak
2019-09-27 13:32 ` Imre Deak
2019-09-27 13:40 ` Jani Nikula [this message]
2019-09-27 14:33 ` Imre Deak
2019-09-26 14:56 ` [PATCH v9 4/7] drm/i915/tgl: Do modeset to enable and configure DC3CO exitline Anshuman Gupta
2019-09-27 15:09 ` Imre Deak
2019-09-26 14:56 ` [PATCH v9 5/7] drm/i915/tgl: DC3CO PSR2 helper Anshuman Gupta
2019-09-27 15:49 ` Imre Deak
2019-09-26 14:56 ` [PATCH v9 6/7] drm/i915/tgl: switch between dc3co and dc5 based on display idleness Anshuman Gupta
2019-09-27 16:18 ` Imre Deak
2019-09-26 14:56 ` [PATCH v9 7/7] drm/i915/tgl: Add DC3CO counter in i915_dmc_info Anshuman Gupta
2019-09-27 16:38 ` Imre Deak
2019-09-27 16:57 ` Anshuman Gupta
2019-09-30 11:45 ` Imre Deak
2019-09-26 16:03 ` ✗ Fi.CI.CHECKPATCH: warning for DC3CO Support for TGL (rev12) Patchwork
2019-09-26 16:29 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-27 13:03 ` ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-09-25 18:10 [PATCH v9 0/7] DC3CO Support for TGL Anshuman Gupta
2019-09-25 18:10 ` [PATCH v9 3/7] drm/i915/tgl: Enable DC3CO state in "DC Off" power well Anshuman Gupta
2019-09-26 3:56 ` Anshuman Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9tddfh0.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox