From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH v2] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier()
Date: Thu, 21 Mar 2019 12:01:13 +0200 [thread overview]
Message-ID: <87va0czguu.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190321092451.GK2202@kadam>
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The mock_context() function returns NULL on error, it doesn't return
> error pointers.
>
> Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> V2: I accidentally sent a bunch of unrelated stuff...
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> index 4399ef9ebf15..a172dbd9cb9e 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> @@ -1620,8 +1620,8 @@ static int mock_context_barrier(void *arg)
> mutex_lock(&i915->drm.struct_mutex);
>
> ctx = mock_context(i915, "mock");
> - if (IS_ERR(ctx)) {
> - err = PTR_ERR(ctx);
> + if (!ctx) {
> + err = -ENOMEM;
> goto unlock;
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-21 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 8:33 [PATCH] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() Dan Carpenter
2019-03-21 8:58 ` Mika Kuoppala
2019-03-21 9:22 ` Dan Carpenter
2019-03-21 9:24 ` [PATCH v2] " Dan Carpenter
2019-03-21 10:01 ` Mika Kuoppala [this message]
2019-03-21 13:31 ` Chris Wilson
2019-03-21 9:25 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-21 12:40 ` ✓ Fi.CI.BAT: success for drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() (rev2) Patchwork
2019-03-22 0:26 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va0czguu.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox