From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Shi, Yang A" <yang.a.shi@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "He, Bo" <bo.he@intel.com>
Subject: Re: [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it
Date: Tue, 10 Apr 2018 10:56:33 +0300 [thread overview]
Message-ID: <87vaczijf2.fsf@intel.com> (raw)
In-Reply-To: <E3ED5BF57CCD1C40876FA2D3385ED5D37B616F84@SHSMSX101.ccr.corp.intel.com>
On Tue, 10 Apr 2018, "Shi, Yang A" <yang.a.shi@intel.com> wrote:
> issue: snd_soc_skl meet "failed to add i915 component master (-19)"
> when platform don't connect any display output.
>
> i915 do initialization before than skl_probe, but if there is no
> display output connect, in function drm_dp_dpcd_access, there is a 32
> retry for aux i2c transactions. It will meet timeout and do
> usleep. Then skl_probe function will be scheduled. It will call
> snd_hdac_i915_init, and it will meet "failed to add i915 component
> master" error. And whole snd_soc_skl initialization will be failed,
> audio can't work normally anymore.
>
> So i915 driver need to move intel_audio_init at the beginning of
> intel_modeset_init. This will make sure i915_audio_component_init
> process before snd_hdac_i915_init call it.
We do intel_audio_init() and register the audio component when we are
ready to handle the audio component calls. We are ready at
i915_driver_register(). We are not ready at intel_modeset_init().
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-04-10 7:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 7:12 [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it Yang
2018-03-29 8:07 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] " Patchwork
2018-03-29 8:25 ` ✓ Fi.CI.BAT: success " Patchwork
2018-03-29 11:39 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-29 11:55 ` [PATCH 1/1] " Chris Wilson
2018-03-29 13:15 ` Jani Nikula
2018-04-10 7:23 ` Shi, Yang A
2018-04-10 7:56 ` Jani Nikula [this message]
2018-04-10 8:21 ` Shi, Yang A
2018-04-10 10:57 ` Jani Nikula
2018-04-10 13:58 ` Jani Nikula
2018-04-11 1:37 ` Lucas De Marchi
[not found] ` <E3ED5BF57CCD1C40876FA2D3385ED5D37B6183A4@SHSMSX101.ccr.corp.intel.com>
2018-04-11 12:25 ` Jani Nikula
2018-04-12 3:32 ` Shi, Yang A
2018-04-12 8:06 ` Jani Nikula
2018-04-12 8:22 ` Shi, Yang A
2018-04-11 2:07 ` Shi, Yang A
2018-04-11 9:48 ` Jani Nikula
2018-04-10 7:14 ` Shi, Yang A
2018-04-27 7:59 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaczijf2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=bo.he@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=yang.a.shi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox