From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: John Harrison <john.c.harrison@intel.com>
Cc: IGT-Dev@Lists.FreeDesktop.Org, Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/intel_decode: Decode Gen12 ring/batch instructions correctly
Date: Mon, 01 May 2023 13:01:45 -0700 [thread overview]
Message-ID: <87wn1rkehi.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <99a016bd-d3da-154c-4bca-46ff66bb1932@intel.com>
On Mon, 01 May 2023 12:44:14 -0700, John Harrison wrote:
>
> On 4/26/2023 14:51, Dixit, Ashutosh wrote:
> > On Tue, 25 Apr 2023 13:19:25 -0700, John.C.Harrison@Intel.com wrote:
> >> @@ -3623,7 +3624,17 @@ decode_3d_965(struct intel_decode *ctx)
> >> return len;
> >>
> >> case 0x7a00:
> >> - if (IS_GEN6(devid) || IS_GEN7(devid)) {
> >> + if (IS_GEN12(devid)) {
> >> + if (len != 6)
> >> + fprintf(out, "Bad count in PIPE_CONTROL\n");
> >> + instr_out(ctx, 0, "PIPE_CONTROL\n");
> >> + instr_out(ctx, 1, "flags\n");
> >> + instr_out(ctx, 2, "write address low\n");
> >> + instr_out(ctx, 3, "write address high\n");
> >> + instr_out(ctx, 4, "write data low\n");
> >> + instr_out(ctx, 5, "write data high\n");
> >> + return len;
> > Is there a reference for this? I can review but have no idea what's going
> > on here. The rest of the patch looks good. Thanks.
> Just the bspec definition of PIPE_CONTROL. On later gens it has more data -
> 64bit rather than 32bit addressing I think.
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2023-05-01 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 20:19 [Intel-gfx] [PATCH i-g-t 0/2] Update intel_error_decode for Gen12 John.C.Harrison
2023-04-25 20:19 ` [Intel-gfx] [PATCH i-g-t 1/2] lib/intel_decode: Decode Gen12 ring/batch instructions correctly John.C.Harrison
2023-04-26 21:51 ` Dixit, Ashutosh
2023-05-01 19:44 ` John Harrison
2023-05-01 20:01 ` Dixit, Ashutosh [this message]
2023-04-25 20:19 ` [Intel-gfx] [PATCH i-g-t 2/2] tools/intel_error_decode: Correctly name the GuC CT buffer John.C.Harrison
2023-04-26 21:49 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn1rkehi.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=IGT-Dev@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox