Re: [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 08 Jun 2022, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 06/05/2022 13:04, Jani Nikula wrote:
>> Fix:
>> 
>> drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol
>> 'intel_pxp_debugfs_register' was not declared. Should it be static?
>> 
>> Sort and remove the redundant pxp prefixes from the includes while at
>> it.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>   drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
>> index c9da1015eb42..e888b5124a07 100644
>> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
>> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
>> @@ -9,9 +9,10 @@
>>   #include <drm/drm_print.h>
>>   
>>   #include "gt/intel_gt_debugfs.h"
>> -#include "pxp/intel_pxp.h"
>> -#include "pxp/intel_pxp_irq.h"
>>   #include "i915_drv.h"
>> +#include "intel_pxp.h"
>> +#include "intel_pxp_debugfs.h"
>> +#include "intel_pxp_irq.h"
>>   
>>   static int pxp_info_show(struct seq_file *m, void *data)
>>   {
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Thanks, pushed to din.

BR,
Jani.

>
> Lets try to copy domain owners when doing cleanups to lessen the 
> maintainer load, since it appears people are not really scanning the 
> upstream mailing list these days. :(
>
> Regards,
>
> Tvrtko

-- 
Jani Nikula, Intel Open Source Graphics Center