Re: [Intel-gfx] [PATCH] drm/i915: Remove unused intel_gmbus_set_speed() function

[Jani Nikula <jani.nikula@linux.intel.com>]

On Sun, 21 Nov 2021, Hans de Goede <hdegoede@redhat.com> wrote:
> The intel_gmbus_set_speed() function is not used anywhere, remove it.
>
> Note drivers/gpu/drm/gma500 has its own copy called
> gma_intel_gmbus_set_speed() which is used, the intel_gmbus_set_speed()
> version in the i915 code is not used at all

Wow, the last user might have been removed by me. In 2012.

commit 6cb1612a7dc4c3d5ed86dba5dd21bb48a5c395af
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Mon Oct 22 16:12:17 2012 +0300

    drm/i915/sdvo: force GPIO bit-banging also on default pin

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/gpu/drm/i915/display/intel_gmbus.c | 7 -------
>  drivers/gpu/drm/i915/display/intel_gmbus.h | 1 -
>  2 files changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
> index ceb1bf8a8c3c..343f85543446 100644
> --- a/drivers/gpu/drm/i915/display/intel_gmbus.c
> +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
> @@ -922,13 +922,6 @@ struct i2c_adapter *intel_gmbus_get_adapter(struct drm_i915_private *dev_priv,
>  	return &dev_priv->gmbus[pin].adapter;
>  }
>  
> -void intel_gmbus_set_speed(struct i2c_adapter *adapter, int speed)
> -{
> -	struct intel_gmbus *bus = to_intel_gmbus(adapter);
> -
> -	bus->reg0 = (bus->reg0 & ~(0x3 << 8)) | speed;
> -}
> -
>  void intel_gmbus_force_bit(struct i2c_adapter *adapter, bool force_bit)
>  {
>  	struct intel_gmbus *bus = to_intel_gmbus(adapter);
> diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.h b/drivers/gpu/drm/i915/display/intel_gmbus.h
> index b96212b85425..8edc2e99cf53 100644
> --- a/drivers/gpu/drm/i915/display/intel_gmbus.h
> +++ b/drivers/gpu/drm/i915/display/intel_gmbus.h
> @@ -41,7 +41,6 @@ int intel_gmbus_output_aksv(struct i2c_adapter *adapter);
>  
>  struct i2c_adapter *
>  intel_gmbus_get_adapter(struct drm_i915_private *dev_priv, unsigned int pin);
> -void intel_gmbus_set_speed(struct i2c_adapter *adapter, int speed);
>  void intel_gmbus_force_bit(struct i2c_adapter *adapter, bool force_bit);
>  bool intel_gmbus_is_forced_bit(struct i2c_adapter *adapter);
>  void intel_gmbus_reset(struct drm_i915_private *dev_priv);

-- 
Jani Nikula, Intel Open Source Graphics Center