From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 06/12] drm/i915/bios: rename display_device_data to intel_bios_encoder_data
Date: Wed, 17 Feb 2021 21:52:15 +0200 [thread overview]
Message-ID: <87wnv6a2vk.fsf@intel.com> (raw)
In-Reply-To: <20210217174415.vwqcuyyqjstif7jp@ldmartin-desk1>
On Wed, 17 Feb 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Wed, Feb 17, 2021 at 07:03:36PM +0200, Jani Nikula wrote:
>>Make the naming suitable for exposing to the rest of the driver as an
>>opaque type. No functional changes.
>
> ack, but..
>
>>
>>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>---
>> drivers/gpu/drm/i915/display/intel_bios.c | 30 +++++++++++------------
>> 1 file changed, 15 insertions(+), 15 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>>index 59d315b395c2..0e882da165be 100644
>>--- a/drivers/gpu/drm/i915/display/intel_bios.c
>>+++ b/drivers/gpu/drm/i915/display/intel_bios.c
>>@@ -59,7 +59,7 @@
>> */
>>
>> /* Wrapper for VBT child device config */
>>-struct display_device_data {
>>+struct intel_bios_encoder_data {
>> struct child_device_config child;
>> struct dsc_compression_parameters_entry *dsc;
>> struct list_head node;
>>@@ -600,7 +600,7 @@ static void
>> parse_sdvo_device_mapping(struct drm_i915_private *i915)
>> {
>> struct sdvo_device_mapping *mapping;
>>- const struct display_device_data *devdata;
>>+ const struct intel_bios_encoder_data *devdata;
>
> shouldn't we also replace devdata with a better name?
Yes, see cover letter. :)
I've rolled with devdata for now because that's what was there.
BR,
Jani.
>
> Lucas De Marchi
>
>> const struct child_device_config *child;
>> int count = 0;
>>
>>@@ -1439,7 +1439,7 @@ parse_compression_parameters(struct drm_i915_private *i915,
>> const struct bdb_header *bdb)
>> {
>> const struct bdb_compression_parameters *params;
>>- struct display_device_data *devdata;
>>+ struct intel_bios_encoder_data *devdata;
>> const struct child_device_config *child;
>> u16 block_size;
>> int index;
>>@@ -1760,7 +1760,7 @@ static enum port dvo_port_to_port(struct drm_i915_private *i915,
>> }
>>
>> static void parse_ddi_port(struct drm_i915_private *i915,
>>- struct display_device_data *devdata)
>>+ struct intel_bios_encoder_data *devdata)
>> {
>> const struct child_device_config *child = &devdata->child;
>> struct ddi_vbt_port_info *info;
>>@@ -1908,7 +1908,7 @@ static void parse_ddi_port(struct drm_i915_private *i915,
>>
>> static void parse_ddi_ports(struct drm_i915_private *i915)
>> {
>>- struct display_device_data *devdata;
>>+ struct intel_bios_encoder_data *devdata;
>>
>> if (!HAS_DDI(i915) && !IS_CHERRYVIEW(i915))
>> return;
>>@@ -1925,7 +1925,7 @@ parse_general_definitions(struct drm_i915_private *i915,
>> const struct bdb_header *bdb)
>> {
>> const struct bdb_general_definitions *defs;
>>- struct display_device_data *devdata;
>>+ struct intel_bios_encoder_data *devdata;
>> const struct child_device_config *child;
>> int i, child_device_num;
>> u8 expected_size;
>>@@ -2063,7 +2063,7 @@ init_vbt_missing_defaults(struct drm_i915_private *i915)
>> return;
>>
>> for_each_port_masked(port, ports) {
>>- struct display_device_data *devdata;
>>+ struct intel_bios_encoder_data *devdata;
>> struct child_device_config *child;
>> enum phy phy = intel_port_to_phy(i915, port);
>>
>>@@ -2302,7 +2302,7 @@ void intel_bios_init(struct drm_i915_private *i915)
>> */
>> void intel_bios_driver_remove(struct drm_i915_private *i915)
>> {
>>- struct display_device_data *devdata, *n;
>>+ struct intel_bios_encoder_data *devdata, *n;
>>
>> list_for_each_entry_safe(devdata, n, &i915->vbt.display_devices, node) {
>> list_del(&devdata->node);
>>@@ -2333,7 +2333,7 @@ void intel_bios_driver_remove(struct drm_i915_private *i915)
>> */
>> bool intel_bios_is_tv_present(struct drm_i915_private *i915)
>> {
>>- const struct display_device_data *devdata;
>>+ const struct intel_bios_encoder_data *devdata;
>> const struct child_device_config *child;
>>
>> if (!i915->vbt.int_tv_support)
>>@@ -2376,7 +2376,7 @@ bool intel_bios_is_tv_present(struct drm_i915_private *i915)
>> */
>> bool intel_bios_is_lvds_present(struct drm_i915_private *i915, u8 *i2c_pin)
>> {
>>- const struct display_device_data *devdata;
>>+ const struct intel_bios_encoder_data *devdata;
>> const struct child_device_config *child;
>>
>> if (list_empty(&i915->vbt.display_devices))
>>@@ -2425,7 +2425,7 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *i915, u8 *i2c_pin)
>> */
>> bool intel_bios_is_port_present(struct drm_i915_private *i915, enum port port)
>> {
>>- const struct display_device_data *devdata;
>>+ const struct intel_bios_encoder_data *devdata;
>> const struct child_device_config *child;
>> static const struct {
>> u16 dp, hdmi;
>>@@ -2471,7 +2471,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *i915, enum port port)
>> */
>> bool intel_bios_is_port_edp(struct drm_i915_private *i915, enum port port)
>> {
>>- const struct display_device_data *devdata;
>>+ const struct intel_bios_encoder_data *devdata;
>> const struct child_device_config *child;
>> static const short port_mapping[] = {
>> [PORT_B] = DVO_PORT_DPB,
>>@@ -2534,7 +2534,7 @@ static bool child_dev_is_dp_dual_mode(const struct child_device_config *child,
>> bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *i915,
>> enum port port)
>> {
>>- const struct display_device_data *devdata;
>>+ const struct intel_bios_encoder_data *devdata;
>>
>> list_for_each_entry(devdata, &i915->vbt.display_devices, node) {
>> if (child_dev_is_dp_dual_mode(&devdata->child, port))
>>@@ -2554,7 +2554,7 @@ bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *i915,
>> bool intel_bios_is_dsi_present(struct drm_i915_private *i915,
>> enum port *port)
>> {
>>- const struct display_device_data *devdata;
>>+ const struct intel_bios_encoder_data *devdata;
>> const struct child_device_config *child;
>> u8 dvo_port;
>>
>>@@ -2654,7 +2654,7 @@ bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
>> int dsc_max_bpc)
>> {
>> struct drm_i915_private *i915 = to_i915(encoder->base.dev);
>>- const struct display_device_data *devdata;
>>+ const struct intel_bios_encoder_data *devdata;
>> const struct child_device_config *child;
>>
>> list_for_each_entry(devdata, &i915->vbt.display_devices, node) {
>>--
>>2.20.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-17 19:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 17:03 [Intel-gfx] [PATCH 00/12] drm/i915/bios: vbt child device rework Jani Nikula
2021-02-17 17:03 ` [Intel-gfx] [PATCH 01/12] drm/i915/bios: mass convert dev_priv to i915 Jani Nikula
2021-02-22 18:14 ` Ville Syrjälä
2021-02-17 17:03 ` [Intel-gfx] [PATCH 02/12] drm/i915/bios: store bdb version in i915 Jani Nikula
2021-02-22 18:14 ` Ville Syrjälä
2021-02-17 17:03 ` [Intel-gfx] [PATCH 03/12] drm/i915/bios: limit default outputs by platform on missing VBT Jani Nikula
2021-02-22 18:16 ` Ville Syrjälä
2021-02-17 17:03 ` [Intel-gfx] [PATCH 04/12] drm/i915/bios: limit default outputs to ports A through F Jani Nikula
2021-02-17 17:23 ` Lucas De Marchi
2021-02-17 17:28 ` Lucas De Marchi
2021-02-17 19:49 ` Jani Nikula
2021-02-17 19:58 ` Lucas De Marchi
2021-02-23 13:34 ` Jani Nikula
2021-02-24 0:34 ` Lucas De Marchi
2021-02-17 17:03 ` [Intel-gfx] [PATCH 05/12] drm/i915/bios: create fake child devices on missing VBT Jani Nikula
2021-03-09 0:51 ` Lucas De Marchi
2021-02-17 17:03 ` [Intel-gfx] [PATCH 06/12] drm/i915/bios: rename display_device_data to intel_bios_encoder_data Jani Nikula
2021-02-17 17:44 ` Lucas De Marchi
2021-02-17 19:52 ` Jani Nikula [this message]
2021-02-23 12:50 ` Jani Nikula
2021-02-24 0:37 ` Lucas De Marchi
2021-02-17 17:03 ` [Intel-gfx] [PATCH 07/12] drm/i915/bios: add i915 backpointer " Jani Nikula
2021-02-17 17:03 ` [Intel-gfx] [PATCH 08/12] drm/i915/vbt: add helper functions to check output support Jani Nikula
2021-02-17 17:46 ` Lucas De Marchi
2021-02-17 19:55 ` Jani Nikula
2021-03-15 17:32 ` Lucas De Marchi
2021-03-16 9:18 ` Jani Nikula
2021-02-17 17:03 ` [Intel-gfx] [PATCH 09/12] drm/i915/bios: save a higher level pointer in ddi_vbt_port_info[] Jani Nikula
2021-03-15 17:36 ` Lucas De Marchi
2021-02-17 17:03 ` [Intel-gfx] [PATCH 10/12] drm/i915/bios: start using the intel_bios_encoder_data directly Jani Nikula
2021-03-15 17:41 ` Lucas De Marchi
2021-02-17 17:03 ` [Intel-gfx] [PATCH 11/12] drm/i915/bios: start using intel_bios_encoder_data for Type-C USB and TBT Jani Nikula
2021-03-15 17:49 ` Lucas De Marchi
2021-02-17 17:03 ` [Intel-gfx] [PATCH 12/12] drm/i915/bios: add intel_bios_encoder_data to encoder, use for iboost Jani Nikula
2021-03-15 17:52 ` Lucas De Marchi
2021-02-17 17:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: vbt child device rework Patchwork
2021-02-17 17:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-17 17:54 ` [Intel-gfx] [PATCH 00/12] " Lucas De Marchi
2021-02-17 19:57 ` Jani Nikula
2021-02-17 20:52 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnv6a2vk.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox