From: Jani Nikula <jani.nikula@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Ross Zwisler <zwisler@google.com>
Subject: Re: [Intel-gfx] [PATCH v4-CI] drm/i915/psr: Force PSR probe only after full initialization
Date: Thu, 27 Feb 2020 15:18:26 +0200 [thread overview]
Message-ID: <87wo88qicd.fsf@intel.com> (raw)
In-Reply-To: <20200221212635.11614-1-jose.souza@intel.com>
On Fri, 21 Feb 2020, José Roberto de Souza <jose.souza@intel.com> wrote:
> Commit 60c6a14b489b ("drm/i915/display: Force the state compute phase
> once to enable PSR") was forcing the state compute too earlier
> causing errors because not everything was initialized, so here
> moving to the end of i915_driver_modeset_probe() when the display is
> all initialized.
Hmph, really not happy about the placement here. These are high level
functions, not a dumping ground for random feature specific hacks. :(
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-27 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:26 [Intel-gfx] [PATCH v4-CI] drm/i915/psr: Force PSR probe only after full initialization José Roberto de Souza
2020-02-22 3:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Force PSR probe only after full initialization (rev7) Patchwork
2020-02-24 15:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-02-24 18:53 ` Souza, Jose
2020-02-27 13:18 ` Jani Nikula [this message]
2020-02-27 16:43 ` [Intel-gfx] [PATCH v4-CI] drm/i915/psr: Force PSR probe only after full initialization Ross Zwisler
2020-02-27 16:59 ` Jani Nikula
2020-02-27 17:54 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo88qicd.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox