From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: debug log max vswing and pre-emphasis
Date: Tue, 21 Jan 2020 17:49:39 +0200 [thread overview]
Message-ID: <87wo9kern0.fsf@intel.com> (raw)
In-Reply-To: <20200121143252.GB13686@intel.com>
On Tue, 21 Jan 2020, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Jan 17, 2020 at 05:02:35PM +0200, Jani Nikula wrote:
>> Provide slightly more debugging help.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed to dinq, thanks for the review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 13 ++++++++-----
>> 1 file changed, 8 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index 4074d83b1a5f..c26be4421f01 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -4142,11 +4142,14 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp)
>> if (mask)
>> DRM_DEBUG_KMS("Using signal levels %08x\n", signal_levels);
>>
>> - DRM_DEBUG_KMS("Using vswing level %d\n",
>> - train_set & DP_TRAIN_VOLTAGE_SWING_MASK);
>> - DRM_DEBUG_KMS("Using pre-emphasis level %d\n",
>> - (train_set & DP_TRAIN_PRE_EMPHASIS_MASK) >>
>> - DP_TRAIN_PRE_EMPHASIS_SHIFT);
>> + DRM_DEBUG_KMS("Using vswing level %d%s\n",
>> + train_set & DP_TRAIN_VOLTAGE_SWING_MASK,
>> + train_set & DP_TRAIN_MAX_SWING_REACHED ? " (max)" : "");
>> + DRM_DEBUG_KMS("Using pre-emphasis level %d%s\n",
>> + (train_set & DP_TRAIN_PRE_EMPHASIS_MASK) >>
>> + DP_TRAIN_PRE_EMPHASIS_SHIFT,
>> + train_set & DP_TRAIN_MAX_PRE_EMPHASIS_REACHED ?
>> + " (max)" : "");
>>
>> intel_dp->DP = (intel_dp->DP & ~mask) | signal_levels;
>>
>> --
>> 2.20.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-01-21 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 15:02 [Intel-gfx] [PATCH] drm/i915/dp: debug log max vswing and pre-emphasis Jani Nikula
2020-01-18 0:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-18 0:11 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-20 18:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-01-21 14:32 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2020-01-21 15:49 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo9kern0.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox