From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove unused enable_cmd_parser modparam
Date: Thu, 17 May 2018 18:18:22 +0300 [thread overview]
Message-ID: <87wow248g1.fsf@intel.com> (raw)
In-Reply-To: <20180517150727.10431-1-chris@chris-wilson.co.uk>
On Thu, 17 May 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The command parser is feature complete, stable and required by
> userspace. In commit 41736a8e3331 ("drm/i915: Use the precomputed value
> for whether to enable command parsing") I accidentally removed control
> from the modparam, and as no one has complained, eemove the left
> over modparam completely!
>
> References: 41736a8e3331 ("drm/i915: Use the precomputed value for whether to enable command parsing")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
Another one bites the dust!
Acked-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_params.c | 3 ---
> drivers/gpu/drm/i915/i915_params.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 66ea3552c63e..49fcc4679db6 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -130,9 +130,6 @@ i915_param_named_unsafe(invert_brightness, int, 0600,
> i915_param_named(disable_display, bool, 0400,
> "Disable display (default: false)");
>
> -i915_param_named_unsafe(enable_cmd_parser, bool, 0400,
> - "Enable command parsing (true=enabled [default], false=disabled)");
> -
> i915_param_named(mmio_debug, int, 0600,
> "Enable the MMIO debug code for the first N failures (default: off). "
> "This may negatively affect performance.");
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 6684025b7af8..aebe0469ddaa 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -58,7 +58,6 @@ struct drm_printer;
> param(unsigned int, inject_load_failure, 0) \
> /* leave bools at the end to not create holes */ \
> param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
> - param(bool, enable_cmd_parser, true) \
> param(bool, enable_hangcheck, true) \
> param(bool, fastboot, false) \
> param(bool, prefault_disable, false) \
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-17 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 15:07 [PATCH] drm/i915: Remove unused enable_cmd_parser modparam Chris Wilson
2018-05-17 15:18 ` Jani Nikula [this message]
2018-05-17 15:23 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-05-17 15:39 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-17 18:22 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wow248g1.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox