public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Arun Siluvery <arun.siluvery@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1 3/4] drm/i915:bxt: Enable Pooled EU	support
Date: Fri, 17 Jul 2015 19:50:13 +0300	[thread overview]
Message-ID: <87wpxyloe2.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20150717162743.GD31965@nuc-i3427.alporthouse.com>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> On Fri, Jul 17, 2015 at 05:08:53PM +0100, Arun Siluvery wrote:
>> This mode allows to assign EUs to pools.
>> The command to enable this mode is sent in auxiliary golden context batch
>> as this is only issued once with each context initialization. Thanks to
>> Mika for the preliminary review.
>
> A quick explanation for why this has to be in the kernel would be nice.
> Privileged instruction?
>

The pooled mode is global. Once set, it has to stay same
across all contexts until subsequent fw reset.

-Mika

> Not fond of the split between this and patch 4. Patch 4 intoduces one
> feature flag that looks different to the one we use here to enable
> support.
> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-07-17 16:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 16:08 [PATCH v1 0/4] Add Pooled EU support to BXT Arun Siluvery
2015-07-17 16:08 ` [PATCH v1 1/4] drm/i915: Do kunmap if renderstate parsing fails Arun Siluvery
2015-07-21  7:26   ` Daniel Vetter
2015-07-17 16:08 ` [PATCH v1 2/4] drm/i915: Add provision to extend Golden context batch Arun Siluvery
2015-07-17 16:23   ` Chris Wilson
2015-07-17 16:37     ` Mika Kuoppala
2015-07-17 16:48       ` Chris Wilson
2015-07-17 16:08 ` [PATCH v1 3/4] drm/i915:bxt: Enable Pooled EU support Arun Siluvery
2015-07-17 16:27   ` Chris Wilson
2015-07-17 16:50     ` Mika Kuoppala [this message]
2015-07-17 16:54     ` Siluvery, Arun
2015-07-17 16:58       ` Chris Wilson
2015-07-17 16:08 ` [PATCH v1 4/4] drm/i915/bxt: Add get_param to query Pooled EU availability Arun Siluvery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpxyloe2.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=arun.siluvery@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox