From: Jani Nikula <jani.nikula@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: Re: [PATCH 1/3] drm/i915/display: Add missing include to intel_vga.c
Date: Tue, 21 May 2024 12:24:58 +0300 [thread overview]
Message-ID: <87y183qzyt.fsf@intel.com> (raw)
In-Reply-To: <20240520181814.2392-2-michal.wajdeczko@intel.com>
On Mon, 20 May 2024, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> This compilation unit uses udelay() function without including
> it's header file. Fix that to break dependency on other code.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
Probably won't be an issue to merge this via xe.
Acked-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_vga.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
> index 4b98833bfa8c..0b5916c15307 100644
> --- a/drivers/gpu/drm/i915/display/intel_vga.c
> +++ b/drivers/gpu/drm/i915/display/intel_vga.c
> @@ -3,6 +3,7 @@
> * Copyright © 2019 Intel Corporation
> */
>
> +#include <linux/delay.h>
> #include <linux/vgaarb.h>
>
> #include <video/vga.h>
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-05-21 9:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 18:18 [PATCH 0/3] drm/xe: Cleanup xe_mmio.h Michal Wajdeczko
2024-05-20 18:18 ` [PATCH 1/3] drm/i915/display: Add missing include to intel_vga.c Michal Wajdeczko
2024-05-21 9:24 ` Jani Nikula [this message]
2024-05-20 18:18 ` [PATCH 2/3] drm/xe: Don't rely on indirect includes from xe_mmio.h Michal Wajdeczko
2024-05-21 14:01 ` Francois Dugast
2024-05-21 14:10 ` Michal Wajdeczko
2024-05-21 14:50 ` Francois Dugast
2024-05-20 18:18 ` [PATCH 3/3] drm/xe: Cleanup xe_mmio.h Michal Wajdeczko
2024-05-22 9:39 ` Ghimiray, Himal Prasad
2024-05-20 19:02 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-05-20 19:02 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-20 19:14 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-21 5:48 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-22 9:54 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y183qzyt.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox