Re: [Intel-gfx] [PATCH] drm/i915/fbc: Disable FBC when VT-d is enabled for Gen9

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 21 Nov 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> The WaFbcTurnOffFbcWhenHyperVisorIsUsed is applicable for all GEN9
> platforms as per BspecID: 0852

The commit subject and commit message do not match the code.

Also, the format for Bspec references is:

Bspec: 0852

next to the other tags. See 'git log --grep=Bspec:'.

BR,
Jani.


>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_fbc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index b5ee5ea0d010..efd5659b3b60 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1652,9 +1652,9 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *i915)
>  
>  static bool need_fbc_vtd_wa(struct drm_i915_private *i915)
>  {
> -	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
> +	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt,cnl,kbl */
>  	if (i915_vtd_active(i915) &&
> -	    (IS_SKYLAKE(i915) || IS_BROXTON(i915))) {
> +	    (DISPLAY_VER(i915) == 9) || DISPLAY_VER(i915) == 10) {
>  		drm_info(&i915->drm,
>  			 "Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n");
>  		return true;

-- 
Jani Nikula, Intel Open Source Graphics Center