Re: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to display.funcs

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 12 Aug 2022, Jani Nikula <jani.nikula@intel.com> wrote:
> On Fri, 12 Aug 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>>> -----Original Message-----
>>> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
>>> Nikula
>>> Sent: Thursday, August 11, 2022 8:37 PM
>>> To: intel-gfx@lists.freedesktop.org
>>> Cc: Nikula, Jani <jani.nikula@intel.com>; De Marchi, Lucas
>>> <lucas.demarchi@intel.com>
>>> Subject: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to
>>> display.funcs
>>>
>>> Move display related members under drm_i915_private display sub-struct.
>>>
>>> Rename struct i915_clock_gating_funcs to intel_clock_gating_funcs while at
>>> it.
>>>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>>  .../gpu/drm/i915/display/intel_display_core.h |  4 ++
>>>  drivers/gpu/drm/i915/i915_drv.h               |  4 --
>>>  drivers/gpu/drm/i915/intel_pm.c               | 58 +++++++++----------
>>>  3 files changed, 33 insertions(+), 33 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h
>>> b/drivers/gpu/drm/i915/display/intel_display_core.h
>>> index ff76bd4079e4..98c6ccdc9100 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_display_core.h
>>> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h
>>> @@ -10,6 +10,7 @@
>>>
>>>  struct intel_atomic_state;
>>>  struct intel_cdclk_funcs;
>>> +struct intel_clock_gating_funcs;
>>>  struct intel_crtc;
>>>  struct intel_crtc_state;
>>>  struct intel_dpll_funcs;
>>> @@ -44,6 +45,9 @@ struct intel_display {
>>>
>>>               /* irq display functions */
>>>               const struct intel_hotplug_funcs *hotplug;
>>> +
>>> +             /* pm private clock gating functions */
>>> +             const struct intel_clock_gating_funcs *clock_gating;
>> Likewise having struct intel_display and all display related structs inside this, can this stuct be moved to intel_pm?
>> This is more related to a pm!
>
> I'm undecided whether it's eventually better to group the functions
> together, or spread the functions by, uh, functionality.
>
> But I'm pretty sure I want to first group them like this, see how the
> *other* named and anonymous sub-structs of intel_display shape up, and
> spread them around if that feels like the right thing to do.

Also, this series is going to be a lot of refactoring, and I'm
constantly trying to *not* incorporate too many changes, and mostly just
stick to straightforward movement. There's a lot more that should be
done wrt actually hiding this stuff within modules (using opaque
pointers etc) instead of exposing all of the data to all of the
drivers. It just can't all be done at once. This is the first step.

BR,
Jani.


>
> BR,
> Jani.
>
>
>>
>> Thanks and Regards,
>> Arun R Murthy
>> --------------------

-- 
Jani Nikula, Intel Open Source Graphics Center