From: Jani Nikula <jani.nikula@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Zhi Wang <zhi.wang.linux@gmail.com>,
Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile
Date: Wed, 13 Apr 2022 19:04:54 +0300 [thread overview]
Message-ID: <87y209ezq1.fsf@intel.com> (raw)
In-Reply-To: <20220413154120.GC27532@lst.de>
On Wed, 13 Apr 2022, Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Apr 13, 2022 at 03:25:37PM +0300, Jani Nikula wrote:
>> This is [1] rebased on gvt-next. (Which means it won't build on CI.)
>
> Btw, now that I found that gvt-next branch:
>
> Zhi, your commits still have per-commit changelog like:
>
> v6:
> - Remove the reference of intel_gvt_device_info.(Christoph)
> - Refine the save_mmio() function. (Christoph)
>
> which don't belong in the commit log. It might be worth to fix that
> before sending a pull request.
I'll just note, without any value judgement, that it is customary in the
drm land to do so. They are fine here even if they're not accepted in
other subsystems. I'm not going to insist one way or the other.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-04-13 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 12:25 [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile Jani Nikula
2022-04-13 12:25 ` [Intel-gfx] [PATCH 1/2] drm/i915/gvt: fix trace TRACE_INCLUDE_PATH Jani Nikula
2022-04-13 15:36 ` Christoph Hellwig
2022-04-13 12:25 ` [Intel-gfx] [PATCH 2/2] drm/i915/gvt: better align the Makefile with i915 Makefile Jani Nikula
2022-04-13 15:37 ` Christoph Hellwig
2022-04-13 13:40 ` [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile Wang, Zhi A
2022-04-13 15:41 ` Christoph Hellwig
2022-04-13 16:04 ` Jani Nikula [this message]
2022-04-13 16:12 ` Christoph Hellwig
2022-04-13 16:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y209ezq1.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox