From: Jani Nikula <jani.nikula@intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH RESEND 6/6] drm/i915/pm: use intel de functions for forcewake register access
Date: Mon, 27 Jan 2020 11:18:56 +0200 [thread overview]
Message-ID: <87y2ttb6kf.fsf@intel.com> (raw)
In-Reply-To: <157979008288.19995.17418209460090937508@skylake-alporthouse-com>
On Thu, 23 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Ville Syrjälä (2020-01-23 14:16:46)
>> On Thu, Jan 23, 2020 at 04:00:04PM +0200, Jani Nikula wrote:
>> > Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
>> > switch to using intel_de_read_fw() and intel_de_write_fw(),
>> > respectively.
>> >
>> > No functional changes.
>> >
>> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> Only a few oddities spotted. Overall series lgtm
>
> Concurred, checkpatch is going to have some very stern words regarding
> some of those lines!
>
>> For all
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> +1
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks for the reviews, I pushed the ones *not* in display/ with hopes
we'll do the mass conversion there (the other series).
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-27 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 13:59 [Intel-gfx] [PATCH RESEND 1/6] drm/i915/dmc: use intel uncore functions for forcewake register access Jani Nikula
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 2/6] drm/i915/display: use intel de " Jani Nikula
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 3/6] drm/i915/irq: " Jani Nikula
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 4/6] drm/i915/gmbus: " Jani Nikula
2020-01-23 14:13 ` Ville Syrjälä
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 5/6] drm/i915/sprite: " Jani Nikula
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 6/6] drm/i915/pm: " Jani Nikula
2020-01-23 14:16 ` Ville Syrjälä
2020-01-23 14:34 ` Chris Wilson
2020-01-27 9:18 ` Jani Nikula [this message]
2020-01-23 14:10 ` [Intel-gfx] [PATCH RESEND 1/6] drm/i915/dmc: use intel uncore " Ville Syrjälä
2020-01-23 14:18 ` Jani Nikula
2020-01-23 14:33 ` Chris Wilson
2020-01-23 23:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/6] " Patchwork
2020-01-23 23:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-25 15:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2ttb6kf.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox