From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Drop a defunct timeline assertion
Date: Thu, 09 Jan 2020 10:14:21 +0200 [thread overview]
Message-ID: <87y2uhf3mq.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200107143826.3298401-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> intel_timeline_enter() has been decoupled from intel_timeline_pin() and
> both enter/exit & pin/unpin are allowed [read expected] to run
> concurrently with one another. The assertion that they had better not is
> stale.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/940
Hmm I got page not found for this even tho other issues are shown :O
References to the decoupling part?
-Mika
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/intel_timeline.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
> index ee5dc4fbdeb9..87716529cd2f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_timeline.c
> +++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
> @@ -348,7 +348,6 @@ void intel_timeline_enter(struct intel_timeline *tl)
> * use atomic to manipulate tl->active_count.
> */
> lockdep_assert_held(&tl->mutex);
> - GEM_BUG_ON(!atomic_read(&tl->pin_count));
>
> if (atomic_add_unless(&tl->active_count, 1, 0))
> return;
> --
> 2.25.0.rc1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-09 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 14:38 [Intel-gfx] [PATCH] drm/i915/gt: Drop a defunct timeline assertion Chris Wilson
2020-01-07 19:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-08 4:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-01-09 8:14 ` Mika Kuoppala [this message]
2020-01-09 8:19 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-01-09 8:30 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2uhf3mq.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox