Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 17/18] drm/i915/gtt: Remove vgpu check for gen6
Date: Fri, 08 Jun 2018 17:06:47 +0300	[thread overview]
Message-ID: <87y3fpwex4.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180608125602.17693-18-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Since vgpu is not supported on Haswell or any other gen6/7, we do not
> need to check and act upon it's enablement.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Matthew Auld <matthew.william.auld@gmail.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 25ad94b1b67e..ca067d9adf54 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -2124,7 +2124,7 @@ static struct i915_hw_ppgtt *gen6_ppgtt_create(struct drm_i915_private *i915)
>  	ppgtt->base.vm.vma_ops.clear_pages = clear_pages;
>  
>  	ppgtt->base.vm.pte_encode = ggtt->vm.pte_encode;
> -	if (intel_vgpu_active(i915) || IS_GEN6(i915))
> +	if (IS_GEN6(i915))
>  		ppgtt->switch_mm = gen6_mm_switch;
>  	else if (IS_GEN7(i915))
>  		ppgtt->switch_mm = gen7_mm_switch;
> -- 
> 2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-06-08 14:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 12:55 Haswell full-ppgtt, no really Chris Wilson
2018-06-08 12:55 ` [PATCH 01/18] drm/i915: Apply batch location restrictions before pinning Chris Wilson
2018-06-08 12:55 ` [PATCH 02/18] drm/i915/ringbuffer: Brute force context restore Chris Wilson
2018-06-08 13:52   ` Mika Kuoppala
2018-06-08 14:00     ` Chris Wilson
2018-06-08 12:55 ` [PATCH 03/18] drm/i915/ringbuffer: Fix context restore upon reset Chris Wilson
2018-06-08 14:26   ` Chris Wilson
2018-06-08 17:26   ` [PATCH v2] " Chris Wilson
2018-06-08 12:55 ` [PATCH 04/18] drm/i915/gtt: Invalidate GGTT caches after writing the gen6 page directories Chris Wilson
2018-06-08 12:55 ` [PATCH 05/18] drm/i915/gtt: Subclass gen6_hw_ppgtt Chris Wilson
2018-06-08 12:55 ` [PATCH 06/18] drm/i915/gtt: Onionify error handling for gen6_ppgtt_create Chris Wilson
2018-06-08 12:55 ` [PATCH 07/18] drm/i915/gtt: Reorder aliasing_ppgtt fini Chris Wilson
2018-06-08 12:55 ` [PATCH 08/18] drm/i915/gtt: Make gen6 page directories evictable Chris Wilson
2018-06-08 13:10   ` [PATCH] " Chris Wilson
2018-06-08 12:55 ` [PATCH 09/18] drm/i915/gtt: Only keep gen6 page directories pinned while active Chris Wilson
2018-06-08 12:55 ` [PATCH 10/18] drm/i915/gtt: Lazily allocate page directories for gen7 Chris Wilson
2018-06-08 14:37   ` Matthew Auld
2018-06-08 14:43     ` Chris Wilson
2018-06-08 12:55 ` [PATCH 11/18] drm/i915/gtt: Free unused page tables on unbind the context Chris Wilson
2018-06-08 12:55 ` [PATCH 12/18] drm/i915/gtt: Skip initializing PT with scratch if full Chris Wilson
2018-06-08 12:55 ` [PATCH 13/18] drm/i915/gtt: Cache the PTE encoding of the scratch page Chris Wilson
2018-06-08 12:55 ` [PATCH 14/18] drm/i915/gtt: Reduce a pair of runtime asserts Chris Wilson
2018-06-08 12:55 ` [PATCH 15/18] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt Chris Wilson
2018-06-08 12:56 ` [PATCH 16/18] drm/i915/gtt: Remove redundant hsw_mm_switch() Chris Wilson
2018-06-08 14:03   ` Mika Kuoppala
2018-06-08 12:56 ` [PATCH 17/18] drm/i915/gtt: Remove vgpu check for gen6 Chris Wilson
2018-06-08 14:06   ` Mika Kuoppala [this message]
2018-06-08 12:56 ` [PATCH 18/18] RFT drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
2018-06-08 13:25 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/18] drm/i915: Apply batch location restrictions before pinning (rev2) Patchwork
2018-06-08 13:30 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-06-08 13:41 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-08 16:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-06-08 16:36   ` Chris Wilson
2018-06-08 17:09     ` Chris Wilson
2018-06-08 18:03 ` ✗ Fi.CI.BAT: failure for series starting with [01/18] drm/i915: Apply batch location restrictions before pinning (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3fpwex4.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox