Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Timo Aaltonen <tjaalton@ubuntu.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: intel-gfx@lists.freedesktop.org,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/i915/cnp: Properly handle VBT ddc pin out of bounds.
Date: Mon, 09 Apr 2018 12:48:15 +0300	[thread overview]
Message-ID: <87y3hwk8ww.fsf@intel.com> (raw)
In-Reply-To: <4c930511-ea7d-e91a-b492-8943980549e4@ubuntu.com>

On Fri, 23 Mar 2018, Timo Aaltonen <tjaalton@ubuntu.com> wrote:
> On 30.01.2018 00:12, Rodrigo Vivi wrote:
>> On Mon, Jan 29, 2018 at 05:42:53AM +0000, Kai Heng Feng wrote:
>>>
>>>> On 26 Jan 2018, at 6:25 AM, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>>>>
>>>> If the table result is out of bounds on the array map
>>>> there is something really wrong with VBT pin so we don't
>>>> return that vbt_pin, but only return 0 instead.
>>>>
>>>> This basically reverts commit 'a8e6f3888b05 ("drm/i915/cnp:
>>>> Ignore VBT request for know invalid DDC pin.")'
>>>>
>>>> Also this properly fixes commit 9c3b2689d01f ("drm/i915/cnl:
>>>> Map VBT DDC Pin to BSpec DDC Pin.")
>>>>
>>>> v2: Do in a way that we don't break other platforms. (Jani)
>>>>
>>>> v3: Keep debug message (Jani)
>>>>
>>>> v4: Don't mess with 0 mapping was noticed by Jani and
>>>>    addressed with a simple solution suggested by Lucas
>>>>    that makes this even simpler.
>>>>
>>>> Fixes: a8e6f3888b05 ("drm/i915/cnp: Ignore VBT request for know invalid DDC pin.")
>>>> Fixes: 9c3b2689d01f ("drm/i915/cnl: Map VBT DDC Pin to BSpec DDC Pin.")
>>>> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>> Cc: Kai Heng Feng <kai.heng.feng@canonical.com>
>>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>>> Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>
>>> Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> 
>> merged. thanks for suggestions, reviews, tests and patience ;)
>
> Shouldn't this and
>
> drm/i915/cnp: Ignore VBT request for know invalid DDC pin.
>
> be cc:stable? Though they aren't even in 4.16 yet.

Apologies for nobody replying. The commits are in v4.16, and I've made a
stable backport request for v4.15.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-04-09  9:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 18:56 [PATCH] drm/i915/cnp: Properly handle VBT ddc pin out of bounds Rodrigo Vivi
2018-01-24 19:39 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-24 22:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-25  4:22 ` [PATCH] " Kai Heng Feng
2018-01-25 10:09 ` Jani Nikula
2018-01-25 15:19   ` Rodrigo Vivi
2018-01-25 15:33     ` Jani Nikula
2018-01-25 15:40       ` Rodrigo Vivi
2018-01-25 15:52         ` Jani Nikula
2018-01-25 18:07           ` Lucas De Marchi
2018-01-25 18:25             ` Rodrigo Vivi
2018-01-25 22:24               ` Rodrigo Vivi
2018-01-25 22:25               ` Rodrigo Vivi
2018-01-25 22:52                 ` Lucas De Marchi
2018-01-29  5:42                 ` Kai Heng Feng
2018-01-29 22:12                   ` Rodrigo Vivi
2018-03-23 13:07                     ` Timo Aaltonen
2018-04-09  9:48                       ` Jani Nikula [this message]
2018-04-09 19:12                         ` Rodrigo Vivi
2018-01-25 18:14           ` Rodrigo Vivi
2018-01-25 15:37 ` ✓ Fi.CI.BAT: success for drm/i915/cnp: Properly handle VBT ddc pin out of bounds. (rev2) Patchwork
2018-01-25 16:02 ` ✓ Fi.CI.BAT: success for drm/i915/cnp: Properly handle VBT ddc pin out of bounds. (rev3) Patchwork
2018-01-25 17:21 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-25 22:46 ` ✓ Fi.CI.BAT: success for drm/i915/cnp: Properly handle VBT ddc pin out of bounds. (rev5) Patchwork
2018-01-26  0:11 ` ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2018-01-25 19:27 [PATCH 07/10] drm/i915: For HPD connected port use hpd_pin instead of port Rodrigo Vivi
2018-01-25 21:37 ` [PATCH] drm/i915/cnp: Properly handle VBT ddc pin out of bounds Rodrigo Vivi
2018-01-25 22:01   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3hwk8ww.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tjaalton@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox