From: Jani Nikula <jani.nikula@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: use BUILD_BUG_ON to ensure platform name has been set up
Date: Tue, 28 Feb 2017 16:09:35 +0200 [thread overview]
Message-ID: <87y3wqe7a8.fsf@intel.com> (raw)
In-Reply-To: <1488285772.3403.13.camel@linux.intel.com>
On Tue, 28 Feb 2017, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> On ti, 2017-02-28 at 13:11 +0200, Jani Nikula wrote:
>> Leave the runtime check in place in case the platform variable itself
>> comes from bogus sources.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> <SNIP>
>
>> @@ -890,6 +890,7 @@ enum intel_platform {
>> INTEL_BROXTON,
>> INTEL_KABYLAKE,
>> INTEL_GEMINILAKE,
>> + INTEL_MAX_PLATFORMS
>> };
>
> Easily confused to be be off by one, INTEL_MAX_PLATFORMS =
> INTEL_GEMINILAKE, so I suggest changing it to INTEL_NUM_PLATFORMS which
> is explicit.
...and wrong. INTEL_MAX_PLATFORMS is not the same as number of supported
platforms.
BR,
Jani.
>
> Regards, Joonas
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-28 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 11:11 [PATCH] drm/i915: use BUILD_BUG_ON to ensure platform name has been set up Jani Nikula
2017-02-28 11:14 ` Chris Wilson
2017-03-01 13:25 ` Jani Nikula
2017-02-28 12:42 ` Joonas Lahtinen
2017-02-28 14:09 ` Jani Nikula [this message]
2017-02-28 13:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3wqe7a8.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox