From: Jani Nikula <jani.nikula@linux.intel.com>
To: libin.yang@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, tiwai@suse.de, daniel.vetter@intel.com
Subject: Re: [PATCH] drm/i915: add audio_ptr pointer check
Date: Wed, 02 Mar 2016 10:00:26 +0200 [thread overview]
Message-ID: <87y4a1s411.fsf@intel.com> (raw)
In-Reply-To: <s5hziuhs4rw.wl-tiwai@suse.de>
On Wed, 02 Mar 2016, Takashi Iwai <tiwai@suse.de> wrote:
> On Wed, 02 Mar 2016 03:24:31 +0100,
> libin.yang@linux.intel.com wrote:
>>
>> From: Libin Yang <libin.yang@linux.intel.com>
>>
>> check to make sure audio_ptr is not NULL before
>> using it.
>
> I don't think non-NULL is mandatory. If any invalid access is seen,
> it should be fixed rather in the audio side.
Agreed.
BR,
Jani
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-02 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 2:24 [PATCH] drm/i915: add audio_ptr pointer check libin.yang
2016-03-02 7:44 ` Takashi Iwai
2016-03-02 7:59 ` Yang, Libin
2016-03-02 8:56 ` Takashi Iwai
2016-03-03 3:01 ` Yang, Libin
2016-03-02 8:00 ` Jani Nikula [this message]
2016-03-02 8:31 ` ✗ Fi.CI.BAT: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4a1s411.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=libin.yang@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox