Re: [PATCH] drm/i915/hdcp: Use correct function to check if encoder is HDMI

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 16 Jan 2025, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 16 Jan 2025, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
>> Use intel_encoder_is_hdmi function which was recently introduced to
>> see if encoder is HDMI or not.
>
> Does this mean we always returned early from
> intel_hdcp_adjust_hdcp_line_rekeying()?
>
> Fixes: ?

And why is there no patch changelog, just two patches on the list, one
with the condition flipped and the other not?


>
> BR,
> Jani.
>
>
>
>
>
>
>>
>> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
>> ---
>>  drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> index 7464b44c8bb3..91d5629cd9f9 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> @@ -41,7 +41,7 @@ intel_hdcp_adjust_hdcp_line_rekeying(struct intel_encoder *encoder,
>>  	u32 rekey_bit = 0;
>>  
>>  	/* Here we assume HDMI is in TMDS mode of operation */
>> -	if (encoder->type != INTEL_OUTPUT_HDMI)
>> +	if (!intel_encoder_is_hdmi(encoder))
>>  		return;
>>  
>>  	if (DISPLAY_VER(display) >= 30) {

-- 
Jani Nikula, Intel