Re: [PATCH] drm/i915/bios: Define eDP pipe joiner feature for VBT

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 08 Jan 2025, "Vodapalli, Ravi Kumar" <ravi.kumar.vodapalli@intel.com> wrote:
> On 1/8/2025 8:06 PM, Dnyaneshwar Bhadane wrote:
>> There is new field "edp pipe joiner feature" size of 2 bytes in the
>> eDP VBT block. Each bit represent panel number to be enable/disable
>> for this feature.
>>
>> Default value:
>> For ARL platform, 0x0000 to keep the feature disabled by default.
>> Xe3lpd onwards, 0xFFFF to keep the feature enable by default by VBT.
>>
>> Bspec: 20142
>> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>> ---
>>   drivers/gpu/drm/i915/display/intel_vbt_defs.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> index e9b809568cd4..2fdad5170896 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> @@ -1090,6 +1090,7 @@ struct bdb_edp {
>>   	u16 edp_dsc_disable;					/* 251+ */
>>   	u16 t6_delay_support;					/* 260+ */
>>   	u16 link_idle_time[16];					/* 260+ */
>> +	u16 edp_pipe_joiner_feature;				/* 261+ */
>
> Better to add variable when we are actually using it in code.

I was asking for usage plans myself, but for VBT definitions I don't
think we've ever been strict about requiring a user.

For one thing, we use the same file for the IGT intel_vbt_decode tool,
and I wouldn't want to block adding the decode there on some kernel
user.

BR,
Jani.


>
> Regards,
> Ravi Kumar V
>
>>   } __packed;
>>   
>>   /*
>

-- 
Jani Nikula, Intel