Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/i915: Drop -Wstringop-overflow
Date: Fri, 12 Jan 2024 18:02:07 +0200	[thread overview]
Message-ID: <87zfxasfpc.fsf@intel.com> (raw)
In-Reply-To: <20240112154912.1775199-1-lucas.demarchi@intel.com>

On Fri, 12 Jan 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> -Wstringop-overflow is broken on GCC11. In future changes it will
> be moved to the normal C flags in the top level Makefile (out of
> Makefile.extrawarn), but accounting for the compiler support.
>
> Just remove it out of i915's forced extra warnings, preparing for the
> upcoming change and avoiding build warnings to show up.
>
> Fixes: 2250c7ead8ad ("drm/i915: enable W=1 warnings by default")
> References: https://lore.kernel.org/all/45ad1d0f-a10f-483e-848a-76a30252edbe@paulmck-laptop/
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index e777686190ca..c13f14edb508 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -17,7 +17,6 @@ subdir-ccflags-y += $(call cc-option, -Wunused-const-variable)
>  subdir-ccflags-y += $(call cc-option, -Wpacked-not-aligned)
>  subdir-ccflags-y += $(call cc-option, -Wformat-overflow)
>  subdir-ccflags-y += $(call cc-option, -Wformat-truncation)
> -subdir-ccflags-y += $(call cc-option, -Wstringop-overflow)
>  subdir-ccflags-y += $(call cc-option, -Wstringop-truncation)
>  # The following turn off the warnings enabled by -Wextra
>  ifeq ($(findstring 2, $(KBUILD_EXTRA_WARN)),)

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-01-12 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 15:49 [PATCH] drm/i915: Drop -Wstringop-overflow Lucas De Marchi
2024-01-12 16:02 ` Jani Nikula [this message]
2024-01-12 16:19 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-01-12 16:19 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-12 16:32 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-12 19:51 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfxasfpc.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox