Re: [Intel-gfx] [PATCH 2/3] drm/i915: Don't hide function calls with side effects

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 14 Feb 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Hiding a function call with side effects inside the
> variable declaration block is a bit rude. Make it
> stand out more.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_backlight.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
> index d1d54870aefd..e196da8c8f71 100644
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -1614,8 +1614,9 @@ static void intel_pwm_disable_backlight(const struct drm_connector_state *conn_s
>  static int intel_pwm_setup_backlight(struct intel_connector *connector, enum pipe pipe)
>  {
>  	struct intel_panel *panel = &connector->panel;
> -	int ret = panel->backlight.pwm_funcs->setup(connector, pipe);
> +	int ret;
>  
> +	ret = panel->backlight.pwm_funcs->setup(connector, pipe);
>  	if (ret < 0)
>  		return ret;

-- 
Jani Nikula, Intel Open Source Graphics Center