From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Don't use the HDMI port color range bit on Valleyview
Date: Wed, 03 Apr 2013 12:33:31 +0300 [thread overview]
Message-ID: <87zjxgrmac.fsf@intel.com> (raw)
In-Reply-To: <1364908210-13748-4-git-send-email-ville.syrjala@linux.intel.com>
On Tue, 02 Apr 2013, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> VLV docs still list the the color range selection bit for the HDMI
> ports, but for DP ports it has been repurposed.
>
> I have no idea whether the HDMI color range selection bit still works
> on VLV, but since we now have to use the PIPECONF color range bit for
> DP, we might as well do the same for HDMI.
I don't have any additional information on this. The patch does what it
says above, so for that:
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index b206a0d..ee4a8da 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -602,7 +602,7 @@ static void intel_hdmi_mode_set(struct drm_encoder *encoder,
> u32 hdmi_val;
>
> hdmi_val = SDVO_ENCODING_HDMI;
> - if (!HAS_PCH_SPLIT(dev))
> + if (!HAS_PCH_SPLIT(dev) && !IS_VALLEYVIEW(dev))
> hdmi_val |= intel_hdmi->color_range;
> if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
> hdmi_val |= SDVO_VSYNC_ACTIVE_HIGH;
> --
> 1.8.1.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-04-03 10:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 13:10 [PATCH 0/3] drm/i915: VLV color range stuff ville.syrjala
2013-04-02 13:10 ` [PATCH 1/3] drm/i915: Introduce i9xx_set_pipeconf() ville.syrjala
2013-04-03 10:08 ` Jani Nikula
2013-04-03 17:06 ` Daniel Vetter
2013-04-03 21:15 ` Daniel Vetter
2013-04-02 13:10 ` [PATCH 2/3] drm/i915: Set PIPECONF color range bit on Valleyview ville.syrjala
2013-04-03 10:11 ` Jani Nikula
2013-04-02 13:10 ` [PATCH 3/3] drm/i915: Don't use the HDMI port " ville.syrjala
2013-04-03 9:33 ` Jani Nikula [this message]
2013-04-03 17:08 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjxgrmac.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox