Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@gmail.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915/dp: Read the HPD status before trying to read the DPCD
Date: Thu, 13 Dec 2012 13:16:27 +0200	[thread overview]
Message-ID: <87zk1i2odw.fsf@intel.com> (raw)
In-Reply-To: <1355341841-4595-3-git-send-email-damien.lespiau@gmail.com>

On Wed, 12 Dec 2012, Damien Lespiau <damien.lespiau@gmail.com> wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> Just like:
>
>  commit a93cd34234db2269fa2481464ffd39263d617aed

This is your local commit id, and will be meaningless upstream.

Otherwise,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>  Author: Damien Lespiau <damien.lespiau@intel.com>
>  Date:   Wed Dec 12 19:37:22 2012 +0000
>
>      drm/i915/hdmi: Read the HPD status before trying to read the EDID
>
> But this time for DiplayPort.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index b2130bc..fe3c22f 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2248,6 +2248,8 @@ static enum drm_connector_status
>  ironlake_dp_detect(struct intel_dp *intel_dp)
>  {
>  	struct drm_device *dev = intel_dp_to_dev(intel_dp);
> +	struct drm_i915_private *dev_priv = dev->dev_private;
> +	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
>  	enum drm_connector_status status;
>  
>  	/* Can't disconnect eDP, but you can close the lid... */
> @@ -2258,6 +2260,9 @@ ironlake_dp_detect(struct intel_dp *intel_dp)
>  		return status;
>  	}
>  
> +	if (!intel_ironlake_digital_port_connected(dev_priv, intel_dig_port))
> +		return connector_status_disconnected;
> +
>  	return intel_dp_detect_dpcd(intel_dp);
>  }
>  
> -- 
> 1.7.11.7
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2012-12-13 11:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-12 19:50 [PATCH 1/4] drm/i915: Cleanup SHOTPLUG_CTL status bits definitions Damien Lespiau
2012-12-12 19:50 ` [PATCH 2/4] drm/i915/hdmi: Read the HPD status before trying to read the EDID Damien Lespiau
2012-12-13  8:40   ` Chris Wilson
2012-12-13 11:11   ` Jani Nikula
2012-12-12 19:50 ` [PATCH 3/4] drm/i915/dp: Read the HPD status before trying to read the DPCD Damien Lespiau
2012-12-13 11:16   ` Jani Nikula [this message]
2012-12-12 19:50 ` [PATCH 4/4] drm/i915/dp: Don't log the DPCD if we are disconnected Damien Lespiau
2012-12-13  8:33   ` Jani Nikula
2012-12-13  8:39 ` [PATCH 1/4] drm/i915: Cleanup SHOTPLUG_CTL status bits definitions Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk1i2odw.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=damien.lespiau@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox