From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Matthew Auld <matthew.auld@intel.com>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/i915/gem_mmap_offset: use cpu_size in always_clear
Date: Mon, 14 Nov 2022 12:07:14 +0100 [thread overview]
Message-ID: <8926f9d4-e88d-fdb0-1b2d-ec51ae4a3c84@intel.com> (raw)
In-Reply-To: <20221107120426.22849-1-matthew.auld@intel.com>
On 07.11.2022 13:04, Matthew Auld wrote:
> If we can't fit the buffer in the CPU visible portion of lmem, then the
> kernel will be unable to migrate the pages on fault on small-bar
> systems. Note that this doesn't restrict where the pages are allocated,
> but should just ensure we don't SIGBUS, if we need to migrate the pages.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7382
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> tests/i915/gem_mmap_offset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
> index 0adeb0b5..b27920de 100644
> --- a/tests/i915/gem_mmap_offset.c
> +++ b/tests/i915/gem_mmap_offset.c
> @@ -750,7 +750,7 @@ static void always_clear(int i915, const struct gem_memory_region *r, int timeou
> struct thread_clear arg = {
> .i915 = i915,
> .region = r->ci,
> - .max = r->size / 2 >> 12, /* in pages */
> + .max = r->cpu_size / 2 >> 12, /* in pages */
> .timeout = timeout,
> };
> const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
prev parent reply other threads:[~2022-11-14 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 12:04 [Intel-gfx] [PATCH i-g-t] tests/i915/gem_mmap_offset: use cpu_size in always_clear Matthew Auld
2022-11-14 11:07 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8926f9d4-e88d-fdb0-1b2d-ec51ae4a3c84@intel.com \
--to=andrzej.hajda@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox