From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Airlie <airlied@redhat.com>, Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Free hardware status page on unload when physically mapped
Date: Thu, 07 Oct 2010 09:19:06 +0100 [thread overview]
Message-ID: <89k77n$p5gseq@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1286430223.4928.5.camel@clockmaker-el6>
On Thu, 07 Oct 2010 15:43:43 +1000, Dave Airlie <airlied@redhat.com> wrote:
> On Wed, 2010-10-06 at 21:24 -0700, Keith Packard wrote:
> > A physically mapped hardware status page is allocated at driver load
> > time but was never freed. Call the existing code to free this page at
> > driver unload time on hardware which uses this kind.
>
> the free_hws gets called after we disappear the mmio mapping for the
> registers. it then writes a register after killing the hws, and oopses.
Right, freeing the hws page is a definite oversight. It looks like we
should only be doing so on the KMS-only path anyway which neatly pulls the
call before the mmio teardown.
Applied with the amendment to -next.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-10-07 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 4:24 [PATCH] drm/i915: Free hardware status page on unload when physically mapped Keith Packard
2010-10-07 5:43 ` Dave Airlie
2010-10-07 8:19 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89k77n$p5gseq@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox