From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
Cc: Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm/i915: Disable FDI link before retraining.
Date: Mon, 09 Aug 2010 10:04:47 +0100 [thread overview]
Message-ID: <89k83a$97blbt@azsmga001.ch.intel.com> (raw)
In-Reply-To: <8u3s8d$j7eqan@orsmga001.jf.intel.com>
On Fri, 06 Aug 2010 22:57:33 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, 06 Aug 2010 14:21:59 -0700, Eric Anholt <eric@anholt.net> wrote:
> > With the drm fix to not re-dpms the crtc, is this one still needed?
>
> No. I had to disable both this and Dave Airlie's double dpms defense, but
> with the drm crtc dpms fix this patch is no longer required.
I was mistaken. I tried the wrong test case, in order to reproduce you
have to change the fb size for which apparently userspace also does
dpms-off/-on around the add fb. Not sure yet why this isn't caught and
reduced to a no-op by drm-core.
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-08-09 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 7:12 [PATCH] drm/i915: Disable FDI link before retraining Chris Wilson
2010-08-06 21:21 ` Eric Anholt
2010-08-06 21:57 ` Chris Wilson
2010-08-09 9:04 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89k83a$97blbt@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@redhat.com \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox