From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tobias Doerffel <tobias.doerffel@gmail.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: intel_overlay_print_error_state() only needed for debugfs (v2)
Date: Thu, 26 Aug 2010 11:02:39 +0100 [thread overview]
Message-ID: <89k83a$9eiufk@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1282780336-9271-1-git-send-email-tobias.doerffel@gmail.com>
On Thu, 26 Aug 2010 01:52:16 +0200, Tobias Doerffel <tobias.doerffel@gmail.com> wrote:
> The function intel_overlay_print_error_state() is called from within
> i915_error_state() in i915_debufs.c which is only built if
> CONFIG_DEBUG_FS is set. When building without this option, seq_printf()
> is not declared in intel_overlay.c and the file fails to compile.
> Furthermore the whole function is superfluous in this case. Therefore
> only build it if CONFIG_DEBUG_FS is set.
>
> Signed-off-by: Tobias Doerffel <tobias.doerffel@gmail.com>
I've already posted a better patch to remove the compile warnings as well.
The simple inclusion of seq_file.h is the best patch to go into mainline
atm, with the more complete patch coming in via drm-intel-next.
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-08-26 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 21:54 [PATCH] drm/i915: intel_overlay_print_error_state() only needed for debugfs Tobias Doerffel
2010-08-25 22:42 ` Paul Menzel
2010-08-25 23:52 ` [PATCH] drm/i915: intel_overlay_print_error_state() only needed for debugfs (v2) Tobias Doerffel
[not found] ` <4C760C89.1000107@gmail.com>
2010-08-26 8:31 ` Tobias Doerffel
2010-08-26 10:02 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89k83a$9eiufk@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tobias.doerffel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox