From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Mark the object as dirty when setting to the CPU write domain.
Date: Sun, 09 May 2010 22:09:51 +0100 [thread overview]
Message-ID: <89kc63$grbfdn@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1273437720-8950-1-git-send-email-chris@chris-wilson.co.uk>
On Sun, 9 May 2010 21:42:00 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Or else we may not write back the written pages upon unbind. For
> example the contents of a batch buffer written using a simple mmap or
> using shmmem pwrite may be discarded if we are forced to evict
> everything whilst pinning the objects for execbuffer.
Daniel Vetter pointed out that all callers of set_to_cpu_domain(write=TRUE)
manually mark the object as dirty, so this cannot be the cause of the
failures that I see. Well I enjoyed my eureka moment, short though it was.
I think that it would be wise to make set_to_cpu_domain() and its callers
behave consistently with set_to_gtt_domain(), whereby the
obj_priv->dirty=1 is done in the common function and not the callers. A
task for tomorrow.
-ickle
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-05-09 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-09 20:42 [PATCH] drm/i915: Mark the object as dirty when setting to the CPU write domain Chris Wilson
2010-05-09 21:09 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89kc63$grbfdn@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox