From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Ensure that while(INREG()) are bounded.
Date: Fri, 06 Aug 2010 22:39:48 +0100 [thread overview]
Message-ID: <89kc63$hm7jul@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <87lj8jmo4m.fsf@pollan.anholt.net>
On Fri, 06 Aug 2010 14:23:37 -0700, Eric Anholt <eric@anholt.net> wrote:
> On Fri, 6 Aug 2010 16:11:54 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Add a new macro, wait_for, to simplify the act of waiting on a register
> > to change state. wait_for() takes three arguments, the condition to
> > inspect on every loop, the maximum amount of time to wait and whether to
> > yield the cpu for a length of time after each check.
>
> These failures seem DRM_ERROR()-worthy. What do you think? But I do
> like the looks of this patch.
Yes, I made them DRM_ERROR, noticed that surrounding code didn't seem to
treat them as errors and made them debug instead.
The ultimate goal I have in mind here is to return the error code and fail
gracefully. Lofty ideals.
In the meantime, it persistently report:
[drm:ironlake_crtc_dpms] *ERROR* failed to turn off cpu pipe
which is worrying (and indeed the reason why Adam first added the
timeout).
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-08-06 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 15:11 [PATCH] drm/i915: Ensure that while(INREG()) are bounded Chris Wilson
2010-08-06 21:23 ` Eric Anholt
2010-08-06 21:39 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89kc63$hm7jul@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox