From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 14/25] drm/i915: use the new iterator in i915_gem_busy_ioctl v2
Date: Fri, 24 Sep 2021 10:08:06 +0100 [thread overview]
Message-ID: <8b4a5e61-b3fb-155c-8a79-069f232f5f20@linux.intel.com> (raw)
In-Reply-To: <20210923075608.2873-14-christian.koenig@amd.com>
On 23/09/2021 08:55, Christian König wrote:
> This makes the function much simpler since the complex
> retry logic is now handled else where.
Please mention the increased cost versus the old implementation (two
atomics per fence when walking vs no atomics).
Regards,
Tvrtko
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++++++++++--------------
> 1 file changed, 14 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_busy.c b/drivers/gpu/drm/i915/gem/i915_gem_busy.c
> index 6234e17259c1..dc72b36dae54 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_busy.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_busy.c
> @@ -82,8 +82,8 @@ i915_gem_busy_ioctl(struct drm_device *dev, void *data,
> {
> struct drm_i915_gem_busy *args = data;
> struct drm_i915_gem_object *obj;
> - struct dma_resv_list *list;
> - unsigned int seq;
> + struct dma_resv_iter cursor;
> + struct dma_fence *fence;
> int err;
>
> err = -ENOENT;
> @@ -109,27 +109,20 @@ i915_gem_busy_ioctl(struct drm_device *dev, void *data,
> * to report the overall busyness. This is what the wait-ioctl does.
> *
> */
> -retry:
> - seq = raw_read_seqcount(&obj->base.resv->seq);
> -
> - /* Translate the exclusive fence to the READ *and* WRITE engine */
> - args->busy = busy_check_writer(dma_resv_excl_fence(obj->base.resv));
> -
> - /* Translate shared fences to READ set of engines */
> - list = dma_resv_shared_list(obj->base.resv);
> - if (list) {
> - unsigned int shared_count = list->shared_count, i;
> -
> - for (i = 0; i < shared_count; ++i) {
> - struct dma_fence *fence =
> - rcu_dereference(list->shared[i]);
> -
> + args->busy = 0;
> + dma_resv_iter_begin(&cursor, obj->base.resv, true);
> + dma_resv_for_each_fence_unlocked(&cursor, fence) {
> + if (dma_resv_iter_is_restarted(&cursor))
> + args->busy = 0;
> +
> + if (dma_resv_iter_is_exclusive(&cursor))
> + /* Translate the exclusive fence to the READ *and* WRITE engine */
> + args->busy |= busy_check_writer(fence);
> + else
> + /* Translate shared fences to READ set of engines */
> args->busy |= busy_check_reader(fence);
> - }
> }
> -
> - if (args->busy && read_seqcount_retry(&obj->base.resv->seq, seq))
> - goto retry;
> + dma_resv_iter_end(&cursor);
>
> err = 0;
> out:
>
next prev parent reply other threads:[~2021-09-24 9:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 7:55 [Intel-gfx] [PATCH 01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5 Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 02/25] dma-buf: add dma_resv_for_each_fence Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 03/25] dma-buf: use new iterator in dma_resv_copy_fences Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 04/25] dma-buf: use new iterator in dma_resv_get_fences v3 Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 05/25] dma-buf: use new iterator in dma_resv_wait_timeout Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 06/25] dma-buf: use new iterator in dma_resv_test_signaled Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 07/25] drm/ttm: use the new iterator in ttm_bo_flush_all_fences Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 08/25] drm/amdgpu: use the new iterator in amdgpu_sync_resv Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 09/25] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 10/25] drm/amdgpu: use new iterator in amdgpu_vm_prt_fini Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 11/25] drm/msm: use new iterator in msm_gem_describe Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 12/25] drm/radeon: use new iterator in radeon_sync_resv Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 13/25] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2 Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 14/25] drm/i915: use the new iterator in i915_gem_busy_ioctl v2 Christian König
2021-09-24 9:08 ` Tvrtko Ursulin [this message]
2021-09-23 7:55 ` [Intel-gfx] [PATCH 15/25] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3 Christian König
2021-09-23 7:55 ` [Intel-gfx] [PATCH 16/25] drm/i915: use the new iterator in i915_request_await_object v2 Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 17/25] drm/i915: use new iterator in i915_gem_object_wait_reservation Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 18/25] drm/i915: use new iterator in i915_gem_object_wait_priority Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 19/25] drm/i915: use new cursor in intel_prepare_plane_fb Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 20/25] drm: use new iterator in drm_gem_fence_array_add_implicit v3 Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 21/25] drm: use new iterator in drm_gem_plane_helper_prepare_fb Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 22/25] drm/nouveau: use the new iterator in nouveau_fence_sync Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 23/25] drm/nouveau: use the new interator in nv50_wndw_prepare_fb Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 24/25] drm/etnaviv: use new iterator in etnaviv_gem_describe Christian König
2021-09-23 7:56 ` [Intel-gfx] [PATCH 25/25] drm/etnaviv: replace dma_resv_get_excl_unlocked Christian König
2021-09-23 12:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5 Patchwork
2021-09-23 12:35 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-09-23 13:05 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-09-24 9:11 ` Tvrtko Ursulin
2021-09-24 9:13 ` Christian König
2021-09-24 10:08 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4a5e61-b3fb-155c-8a79-069f232f5f20@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox