From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Nirmoy Das <nirmoy.das@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Chris Wilson <chris.p.wilson@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/perf: add sentinel to xehp_oa_b_counters
Date: Wed, 12 Jul 2023 11:02:52 +0200 [thread overview]
Message-ID: <8bbfa6c3-fa97-b1e7-d006-a7e2d519b55b@intel.com> (raw)
In-Reply-To: <ab600ab9-9739-f075-c803-160bfc54bca4@linux.intel.com>
On 12.07.2023 00:10, Nirmoy Das wrote:
>
> On 7/11/2023 5:34 PM, Andrzej Hajda wrote:
>> Arrays passed to reg_in_range_table should end with empty record.
>>
>> The patch solves KASAN detected bug with signature:
>> BUG: KASAN: global-out-of-bounds in
>> xehp_is_valid_b_counter_addr+0x2c7/0x350 [i915]
>> Read of size 4 at addr ffffffffa1555d90 by task perf/1518
>>
>> CPU: 4 PID: 1518 Comm: perf Tainted: G U
>> 6.4.0-kasan_438-g3303d06107f3+ #1
>> Hardware name: Intel Corporation Meteor Lake Client Platform/MTL-P
>> DDR5 SODIMM SBS RVP, BIOS MTLPFWI1.R00.3223.D80.2305311348 05/31/2023
>> Call Trace:
>> <TASK>
>> ...
>> xehp_is_valid_b_counter_addr+0x2c7/0x350 [i915]
>>
>> Fixes: 0fa9349dda030f ("drm/i915/perf: complete programming
>> whitelisting for XEHPSDV")
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Thx, pushed.
Regards
Andrzej
>> ---
>> drivers/gpu/drm/i915/i915_perf.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_perf.c
>> b/drivers/gpu/drm/i915/i915_perf.c
>> index 7413c11fb562e9..49c6f1ff11284f 100644
>> --- a/drivers/gpu/drm/i915/i915_perf.c
>> +++ b/drivers/gpu/drm/i915/i915_perf.c
>> @@ -4431,6 +4431,7 @@ static const struct i915_range
>> mtl_oam_b_counters[] = {
>> static const struct i915_range xehp_oa_b_counters[] = {
>> { .start = 0xdc48, .end = 0xdc48 }, /* OAA_ENABLE_REG */
>> { .start = 0xdd00, .end = 0xdd48 }, /* OAG_LCE0_0 -
>> OAA_LENABLE_REG */
>> + {}
>> };
>> static const struct i915_range gen7_oa_mux_regs[] = {
next prev parent reply other threads:[~2023-07-12 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 15:34 [Intel-gfx] [PATCH] drm/i915/perf: add sentinel to xehp_oa_b_counters Andrzej Hajda
2023-07-11 15:35 ` Andi Shyti
2023-07-11 17:35 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-07-11 17:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-11 22:10 ` [Intel-gfx] [PATCH] " Nirmoy Das
2023-07-12 9:02 ` Andrzej Hajda [this message]
2023-07-11 23:09 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bbfa6c3-fa97-b1e7-d006-a7e2d519b55b@intel.com \
--to=andrzej.hajda@intel.com \
--cc=chris.p.wilson@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
--cc=nirmoy.das@intel.com \
--cc=nirmoy.das@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox