From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] gem_wsim: Implement device selection
Date: Tue, 17 Nov 2020 12:33:11 +0000 [thread overview]
Message-ID: <8bdb8c26-cd11-2826-7ecf-89a30bb7d7a8@linux.intel.com> (raw)
In-Reply-To: <160561548452.22621.12237070971991385724@build.alporthouse.com>
On 17/11/2020 12:18, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-11-17 11:40:50)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> -L and -D <device> on the command line.
>>
>> With no device specified tool tries to find i915 discrete or integrated in
>> that order.
>
> Ok, looks straightforward enough. (I still like having an idiot's guide
> with examples of -L output and what to pass to -D).
>
>> + fd = igt_open_card(&card);
>> + igt_require(fd);
>
> Does igt_require() still generate weirdness when used outside of igt
> tests?
It appears to do nothing. But more importantly I don't know how I ended
up with it here. Probably some copy & paste again.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Can I convert to igt_assert and keep the r-b?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-11-17 12:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 11:40 [Intel-gfx] [PATCH i-g-t] gem_wsim: Implement device selection Tvrtko Ursulin
2020-11-17 11:51 ` Chris Wilson
2020-11-17 12:18 ` Chris Wilson
2020-11-17 12:33 ` Tvrtko Ursulin [this message]
2020-11-17 12:37 ` Chris Wilson
2020-11-17 13:59 ` [Intel-gfx] [PATCH i-g-t v2] " Tvrtko Ursulin
2020-11-17 14:06 ` [Intel-gfx] [igt-dev] " Chris Wilson
2020-11-18 11:56 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bdb8c26-cd11-2826-7ecf-89a30bb7d7a8@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox